Repository navigation
Conversation
The Snyk integration only scans the build-image Dockerfiles. Generate a CycloneDX SBOM from 3rd_party/licenses/*INFO.csv and test it with snyk sbom test in a soft-fail Buildkite step.
|
Pinging @elastic/ml-core (Team:ML) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-tools/generate_sbom.py, which turns3rd_party/licenses/*INFO.csvinto a CycloneDX SBOM, and a soft-fail Buildkite step (snyk_sbom_scan) that runssnyk sbom teston it against the org.pkg:generic, PyTorch aspkg:pypi/torch. The rest (abseil, Eigen, MKL, gcc runtime, zlib and others) are printed as not scanned, so a clean result is not read as having checked them.SNYK_TOKENfrom Vault atsecret/ci/elastic-ml-cpp/snyk/api_token, which does not exist yet. Without it the step fails (soft) with a clear message. Draft until the secret is in place.dev-tools/unittest/test_generate_sbom.py; the full dev-tools suite passes locally. The Buildkite step itself has not run.