Fix sudo auth parsing without TTY - #20587
Merged
stanek-michal merged 7 commits intoAug 11, 2026
Merged
Conversation
Contributor
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
hellqvio86
marked this pull request as ready for review
August 7, 2026 06:19
Contributor
|
/test |
Contributor
|
✅ All changelog entries have the correct PR link. |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
stanek-michal
approved these changes
Aug 11, 2026
stanek-michal
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good to merge, thanks!
Contributor
|
Package system - 2.22.3 containing this change is available at https://epr.elastic.co/package/system/2.22.3/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bug
Proposed commit message
Fix system auth sudo parsing without TTY
Sudo log messages do not always include a
TTYfield, particularly whensudo is invoked non-interactively. The auth ingest pipeline now treats the
TTY section as optional while preserving the existing parsing of TTY and sudo
error messages.
The sudo error pattern excludes values beginning with
TTY=so existingmessages continue to populate
system.auth.sudo.ttycorrectly. When TTY isabsent,
system.auth.sudo.ttyremains absent rather than being populated witha placeholder value.
Added a pipeline test fixture covering:
Aug 6 19:42:10 server01 sudo[18432]: alice : PWD=/home/alice ; USER=root ; COMMAND=/usr/bin/idChecklist
authdata stream; no metrics data streams were changed.changelog.ymlfile.