Format JNA errors and supplement tmp file error#6537
Merged
Conversation
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
Contributor
🔍 Preview links for changed docs |
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
2 tasks
stefnestor
commented
May 16, 2026
3 tasks
theletterf
added a commit
that referenced
this pull request
May 17, 2026
) ## Summary The same-repo guard introduced in #6484 (SEC-043) unconditionally blocked fork PRs from triggering the docs review, even when the actor was an Elastic org member. This caused confusion (see #6537) where a repo member checking the box on a fork PR was silently ignored. **Change:** the guard now calls `checkMembershipForUser` before short-circuiting. Org members can trigger reviews on fork PRs; non-members are still blocked. ``` fork PR + non-member → blocked (unchanged) fork PR + org member → allowed (new) same-repo PR → unchanged ``` The companion change in the canonical template is in elastic/oblt-aw#896. ## Test plan - [ ] Fork PR: org member checks the box → `evaluate-trigger` passes, docs review runs - [ ] Fork PR: fork contributor checks the box → `evaluate-trigger` short-circuits, no review - [ ] Same-repo PR: unchanged behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
@stefnestor You should now be able to trigger the PR AI review on your forked PRs, since you're a member of |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Docs review summary
Focus areas
- Style and clarity: Three small grammar/wording issues in the new bullet list (see inline comments). Overall the restructuring is clear and scannable — good improvement.
- Jargon: JNA and
libffiare explained in the preceding paragraph; acronyms are acceptable in context. - Frontmatter and applies_to: Frontmatter is complete and valid.
mapped_pagespreserved correctly. - Content type fit: Troubleshooting/reference hybrid — appropriate for this page.
- Parent issue satisfaction: No linked issue; PR goal (add new error string, reformat existing errors into a list) is satisfied.
Notes
- Vale found no findings. The pre-existing
"{{es}} will create"(future tense) on line 20 was not introduced by this diff and is out of scope.
Generated by Docs review agent for issue #6537 · ● 267.4K
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
marciw
reviewed
May 20, 2026
marciw
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
👋 Adds error strings for JNA temporary directory from here & formats existing into a bullet list for easier scanning because all the info's there but users seem to miss it still.
Generative AI disclosure