Skip to content

[Rule Tuning] Accepted Default Telnet Port Connection#6204

Merged
eric-forte-elastic merged 3 commits into
mainfrom
tune_default_telnet_port
May 28, 2026
Merged

[Rule Tuning] Accepted Default Telnet Port Connection#6204
eric-forte-elastic merged 3 commits into
mainfrom
tune_default_telnet_port

Conversation

@eric-forte-elastic
Copy link
Copy Markdown
Contributor

@eric-forte-elastic eric-forte-elastic commented May 27, 2026

Pull Request

Issue link(s):

Resolves #5576

Summary - What I changed

Small update to filter out false positives such port scanning (a single non-rejected packet is not a TP) and duplicated alerts on connection end in certain firewall applications such as SonicWall.

How To Test

Verify reduction in telemetry.

And/or use RTAs in elastic/cortado#34

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@github-actions
Copy link
Copy Markdown
Contributor

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Ensure that the code is modular and reusable where applicable.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.
  • Conducted system testing, including fleet, import, and create APIs (e.g., run make test-cli, make test-remote-cli, make test-hunting-cli)

Additional Checks

  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that the proper version label is applied to the PR patch, minor, major.

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented May 27, 2026

⛔️ Test failed

Results
  • ❌ Accepted Default Telnet Port Connection (kuery)
    • stack_validation_failed: no_alerts - 0 alerts

@eric-forte-elastic eric-forte-elastic changed the title Tune default telnet port [Rule Tuning] Accepted Default Telnet Port Connection May 27, 2026
@eric-forte-elastic eric-forte-elastic marked this pull request as ready for review May 27, 2026 19:57
@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented May 28, 2026

⛔️ Test failed

Results
  • ❌ Accepted Default Telnet Port Connection (kuery)
    • stack_validation_failed: no_alerts - 0 alerts

@eric-forte-elastic eric-forte-elastic merged commit c4f95d5 into main May 28, 2026
13 checks passed
@eric-forte-elastic eric-forte-elastic deleted the tune_default_telnet_port branch May 28, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rule Tuning] Accepted Default Telnet Port Connection (34fde489-94b0-4500-a76f-b8a157cf9269)

4 participants