Skip to content

[Rule Tunings] AWS ESQL keep fields missing#6014

Open
imays11 wants to merge 2 commits intomainfrom
rule_tunings_aws_keep_esql_fields
Open

[Rule Tunings] AWS ESQL keep fields missing#6014
imays11 wants to merge 2 commits intomainfrom
rule_tunings_aws_keep_esql_fields

Conversation

@imays11
Copy link
Copy Markdown
Contributor

@imays11 imays11 commented Apr 29, 2026

Pull Request

Issue link(s):

Summary - What I changed

Adding missing keep fields to 2 ESQL rules. 1 additional field name change as well.

Testing

Both queries still run as expected in our test cluster

Screenshot 2026-04-29 at 5 06 11 PM

Adding missing keep fields to 2 ESQL rules. 1 additional field name change as well.
@imays11 imays11 self-assigned this Apr 29, 2026
@imays11 imays11 added Integration: AWS AWS related rules Rule: Tuning tweaking or tuning an existing rule Team: TRADE Domain: Cloud labels Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@imays11 imays11 changed the title [Tunings] AWS ESQL keep fields missing [Rule Tunings] AWS ESQL keep fields missing Apr 29, 2026
Comment thread rules/integrations/aws/discovery_s3_rapid_bucket_posture_api_calls.toml Outdated
Comment thread rules/integrations/aws/discovery_s3_rapid_bucket_posture_api_calls.toml Outdated
Comment thread rules/integrations/aws/discovery_s3_rapid_bucket_posture_api_calls.toml Outdated
Co-authored-by: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants