Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
efd6
force-pushed
the
conformance_testing_packetbeat
branch
2 times, most recently
from
September 17, 2026 22:43
06140ea to
088ce9f
Compare
…gent config When elastic-agent runs packetbeat as an OTel receiver it delivers config in a hybrid format: the top-level key is protocols (beat-native) but each list entry contains agent-style per-stream fields including interface, procs, and data_stream. FromStatic read Interfaces only from the top level and Procs not at all, so every per-stream interface device and monitored process list was silently dropped and packetbeat fell back to defaultDevice() on every deployment. Extend the protocol-routing loop in FromStatic to also unpack interface and procs from each entry, matching the approach already used by NewAgentConfig for the process runtime. Add a defaultDevice() fallback for the case where neither top-level nor per-stream interfaces are present. Add a parity test with 16 pre-rendered stream fixtures for the network_traffic integration. Fixes elastic#53010.
efd6
force-pushed
the
conformance_testing_packetbeat
branch
from
September 18, 2026 00:11
088ce9f to
c862304
Compare
efd6
marked this pull request as ready for review
September 18, 2026 03:20
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
This is the first of four changes to add behaviour parity checks between the two configuration pathways.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
How to test this PR locally
Related issues
Use cases
Screenshots
Logs