This repository was archived by the owner on Jan 29, 2024. It is now read-only.
Made the mime type configureable.#17
Open
florianwagner81 wants to merge 1 commit into
Open
Conversation
…plication/json" i.e.
Contributor
|
This cannot be done with a static variable as we can consume 2 differents API within the same request lifetime. |
Author
|
What do you suggest? What is needed:
Possible solution:
Atm I run my queries like this: |
Contributor
|
Possibly disable the check content-type is better ? EntryPoint::$contentType = false; |
Contributor
|
The best option will be to add a options parameters. And of course this will require to change different methods signature. @pokap's solution can work too, but maybe with a different name: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it might be very helpful for others as well to make the default content mime type configurable as it was causing issues for pure "application/json" API i.e.