Skip to content

Extract ATF#get(Constructor/Method)ReceiverType helpers - #1892

Merged
wmdietl merged 13 commits into
eisop:masterfrom
aosen-xiong:atf-receiver-helpers-only
Aug 4, 2026
Merged

Extract ATF#get(Constructor/Method)ReceiverType helpers#1892
wmdietl merged 13 commits into
eisop:masterfrom
aosen-xiong:atf-receiver-helpers-only

Conversation

@aosen-xiong

@aosen-xiong aosen-xiong commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

The test case is preserved and improved in #1850.

aosen-xiong and others added 7 commits July 4, 2026 17:37
… utility methods

This commit fixes an issue where constructor type variable bounds were not being viewpoint-adapted correctly, mirroring the fix that was made for method invocations. It extracts 'getConstructorReceiverType' into a dedicated helper method, adds 'constructorTypeVariableBoundsFromUse', and utilizes it in 'BaseTypeVisitor.visitNewClass'. It also improves API usability by making both 'getMethodReceiverType' and 'getConstructorReceiverType' public and cross-referencing them in Javadocs.
Copilot AI review requested due to automatic review settings July 28, 2026 15:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aosen-xiong
aosen-xiong changed the base branch from atf-helpers to master July 31, 2026 16:37
@aosen-xiong

Copy link
Copy Markdown
Collaborator Author

CI was failing because #1872 was before pinning the Python linter version, so I redirected this branch to merge into master.

Merging this PR can close #1872.

@wmdietl wmdietl changed the title Keep only receiver type helpers Extract ATF#get(Constructor/Method)ReceiverType helpers Aug 4, 2026

@wmdietl wmdietl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wmdietl
wmdietl enabled auto-merge (squash) August 4, 2026 18:37
@wmdietl
wmdietl merged commit 1637810 into eisop:master Aug 4, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants