Skip to content

Bundle 70: Fresh Personal Holdout Runner R1 - #166

Merged
nulleimy merged 29 commits into
feature/bundle-0-bootstrapfrom
feature/bundle-70-fresh-personal-holdout-runner-r1
Aug 23, 2026
Merged

nulleimy merged 29 commits into
feature/bundle-0-bootstrapfrom
feature/bundle-70-fresh-personal-holdout-runner-r1

Conversation

@nulleimy

@nulleimy nulleimy commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Closes #165

Summary

Adds the local-only execution layer for a fresh personal blinded curation holdout under the canonical Bundle 69 Human Review Protocol R2 / Curation Calibration R3 methodology.

Bundle Context

Scope

  • deterministic candidate generation from frozen private snapshot identity only;
  • per-case local MIR analysis and optimizer materialization with failure isolation;
  • engineering-only holdout candidate ledger;
  • frozen 24-case personal holdout, four cases per set role, plus frozen fallback reservoir;
  • challenger evidence frozen only after selection and before reviewer publication;
  • full source CuratedReviewCase records frozen privately for later unblinding/calibration without optimizer rerun;
  • exact canonical branch/SHA + clean-working-tree preflight;
  • reviewer-safe Plan A/B packet with only four R2 curation dimensions;
  • private preregistration/provenance manifest;
  • pre-finalization SHA-256 verification of private/reviewer/CSV files;
  • reviewer case/order/assignment/role binding to the frozen effective cohort;
  • dual prior-exposure exclusion using reviewer-visible sequences + stable track-ID sequences from private manifests;
  • explicit human/attestation CSV fields left empty at freeze;
  • immutable R1 effective cohort after reviewer publication;
  • local CLI, runbook, adversarial/isolation/security tests.

Critical invariants

  • holdout selection receives no human preferences, ratings, notes, challenger scores, or challenger preferences;
  • a MIR/analyzer failure affects only cases that require the failed evidence and does not abort the entire pool;
  • frozen private source cases preserve plan IDs, path IDs, and ordered track IDs required for post-review unblinding/R3 calibration;
  • changed case IDs/display metadata cannot bypass prior-exposure exclusion;
  • reviewer-safe outputs contain no absolute paths, stable track IDs, optimizer strategy identity, challenger scores, or challenger preference;
  • transition execution is not requested;
  • no human labels, attestation claims, confidence, or timestamps are fabricated;
  • a technical invalidity discovered after reviewer publication aborts/restarts R1 rather than swapping a fallback in-review;
  • actual Fresh Personal Holdout Run must not execute until this bundle is canonical;
  • no optimizer/release/deploy/production/PDM authority.

Verification

Exact HEAD: baa7e8312ef02907e01042ab4fb6d841720e5108

  • PR Guard #382: SUCCESS
  • CI #1026: SUCCESS
  • Python 3.11.16: 533 passed, 6 warnings
  • Python 3.12.14: 533 passed, 5 warnings
  • compile: PASS on 3.11 + 3.12
  • critical Ruff E9,F63,F7,F82: PASS on 3.11 + 3.12
  • Python 3.11 artifact ID: 9492270480
  • Python 3.11 artifact SHA-256: 44adee1ea241e9b2620c3059a5761eaeab8788c2de40a7214c41ce0285bb4cb0
  • Python 3.12 artifact ID: 9492269541
  • Python 3.12 artifact SHA-256: 65d8089109b87b6b700a892a8790cf21558ec0b4be26bf504ec6607d852c57cd
  • scope audit: 9 added Bundle70 files, 0 existing files modified/deleted
  • branch behind canonical base: 0
  • late Codex P1 MIR-isolation finding: FIXED + regression test
  • late Codex P1 frozen-source-case finding: FIXED + regression test
  • both P1 review threads: RESOLVED
  • Set Engine blob unchanged: dd8f0cdb672202289530579d092cf0feb5cedf25
  • Set Path Optimizer blob unchanged: 819f6399181f4b37bb26ed8ccefb6cc0f4a9607f
  • Bundle 67 Competitive Curation blob unchanged: faadcae932e5f7b907503cbf2cd5bfdaab36462e

READY_FOR_MERGE=YES

Authority

MERGE_AUTHORIZATION=YES — explicit user MERGE GO
OPTIMIZER_RANKING_ACTIVATION=NO
PDM_TRAINING=NO
RELEASE_AUTHORIZATION=NO
DEPLOY_AUTHORIZATION=NO
PRODUCTION_ACTIVATION=NO

Eimy Herrer added 26 commits August 23, 2026 10:35

@nulleimy nulleimy left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skill Tester final verification on exact HEAD e3c8d3e27e6b993527c6bd9c39a14bcd0cbca890: PASS. No unresolved HIGH/CRITICAL findings after candidate-failure isolation, exact canonical checkout preflight, empty human-attestation fields at freeze, pre-finalization SHA binding, exact effective-cohort/assignment/role binding, dual reviewer-visible + stable track-ID prior-exposure exclusion, reviewer leakage checks, and immutable R1 cohort/no in-review fallback substitution. CI #1020 PASS: 531 passed on Python 3.11 and 3.12; PR Guard #377 PASS. This review does not authorize merge, optimizer activation, release, deploy, production, or PDM training.

@nulleimy
nulleimy marked this pull request as ready for review August 23, 2026 09:00

@nulleimy nulleimy left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-Ready gate on unchanged exact HEAD e3c8d3e27e6b993527c6bd9c39a14bcd0cbca890: PR Guard #378 SUCCESS and PR Guard #379 SUCCESS after Ready-for-Review transition. CI #1020 remains SUCCESS. READY_FOR_REVIEW=YES. MERGE_AUTHORIZATION=NO; separate explicit MERGE GO is still required.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3c8d3e27e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/intelligence/fresh_personal_holdout_runner.py Outdated
Comment thread services/intelligence/fresh_personal_holdout_runner.py

Copy link
Copy Markdown
Collaborator Author

@codex review

Please re-review exact HEAD baa7e8312ef02907e01042ab4fb6d841720e5108, with focus on the two previously reported P1 findings: per-case MIR failure isolation before materialization, and persistence of full frozen source CuratedReviewCase records needed for later unblinding/calibration without optimizer rerun.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: baa7e8312e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

snapshot_raw=snapshot_raw,
selection_raw=_single_case_selection(selection_raw, spec),
)
except RealLibraryPilotError as exc:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Catch actual MIR provider failures at the case boundary

When one selected audio file is corrupt, empty, non-finite, or silent, this boundary still aborts the entire run because it catches only RealLibraryPilotError. Fresh evidence at exact HEAD is that BaselineLibrosaMIR.analyze directly raises ValueError for several invalid-audio conditions and allows decoder exceptions from librosa.load to propagate, while analyze_real_tracks does not translate them. Catch and classify the expected provider/decoder exceptions here, or normalize them inside analyze_real_tracks, so only cases depending on that track become technically ineligible.

Useful? React with 👍 / 👎.

Comment on lines +158 to +161
case_evidence = analyze_real_tracks(
snapshot_raw=snapshot_raw,
selection_raw=_single_case_selection(selection_raw, spec),
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Cache MIR evidence per track before assembling cases

For an accepted 17-track snapshot with the defaults, the 48 generated cases each contain all 17 tracks, so this loop performs 816 full audio decodes and MIR analyses instead of 17; larger libraries with overlapping scopes also repeatedly analyze shared tracks. Since these are full-length local tracks and the previous union analysis processed each unique track once, this can make the holdout run tens of times slower. Analyze each unique track once with per-track failure isolation, then build each case's evidence map from the successful cache.

Useful? React with 👍 / 👎.

@nulleimy
nulleimy merged commit 375a8d7 into feature/bundle-0-bootstrap Aug 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle 70: Fresh Personal Holdout Runner R1

1 participant