Conversation
nulleimy
left a comment
There was a problem hiding this comment.
Skill Tester final verification on exact HEAD e3c8d3e27e6b993527c6bd9c39a14bcd0cbca890: PASS. No unresolved HIGH/CRITICAL findings after candidate-failure isolation, exact canonical checkout preflight, empty human-attestation fields at freeze, pre-finalization SHA binding, exact effective-cohort/assignment/role binding, dual reviewer-visible + stable track-ID prior-exposure exclusion, reviewer leakage checks, and immutable R1 cohort/no in-review fallback substitution. CI #1020 PASS: 531 passed on Python 3.11 and 3.12; PR Guard #377 PASS. This review does not authorize merge, optimizer activation, release, deploy, production, or PDM training.
nulleimy
left a comment
There was a problem hiding this comment.
Post-Ready gate on unchanged exact HEAD e3c8d3e27e6b993527c6bd9c39a14bcd0cbca890: PR Guard #378 SUCCESS and PR Guard #379 SUCCESS after Ready-for-Review transition. CI #1020 remains SUCCESS. READY_FOR_REVIEW=YES. MERGE_AUTHORIZATION=NO; separate explicit MERGE GO is still required.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3c8d3e27e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact HEAD |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa7e8312e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| snapshot_raw=snapshot_raw, | ||
| selection_raw=_single_case_selection(selection_raw, spec), | ||
| ) | ||
| except RealLibraryPilotError as exc: |
There was a problem hiding this comment.
Catch actual MIR provider failures at the case boundary
When one selected audio file is corrupt, empty, non-finite, or silent, this boundary still aborts the entire run because it catches only RealLibraryPilotError. Fresh evidence at exact HEAD is that BaselineLibrosaMIR.analyze directly raises ValueError for several invalid-audio conditions and allows decoder exceptions from librosa.load to propagate, while analyze_real_tracks does not translate them. Catch and classify the expected provider/decoder exceptions here, or normalize them inside analyze_real_tracks, so only cases depending on that track become technically ineligible.
Useful? React with 👍 / 👎.
| case_evidence = analyze_real_tracks( | ||
| snapshot_raw=snapshot_raw, | ||
| selection_raw=_single_case_selection(selection_raw, spec), | ||
| ) |
There was a problem hiding this comment.
Cache MIR evidence per track before assembling cases
For an accepted 17-track snapshot with the defaults, the 48 generated cases each contain all 17 tracks, so this loop performs 816 full audio decodes and MIR analyses instead of 17; larger libraries with overlapping scopes also repeatedly analyze shared tracks. Since these are full-length local tracks and the previous union analysis processed each unique track once, this can make the holdout run tens of times slower. Analyze each unique track once with per-track failure isolation, then build each case's evidence map from the successful cache.
Useful? React with 👍 / 👎.
Closes #165
Summary
Adds the local-only execution layer for a fresh personal blinded curation holdout under the canonical Bundle 69 Human Review Protocol R2 / Curation Calibration R3 methodology.
Bundle Context
feature/bundle-0-bootstrap27af5d04e1f7971126adef74dff4d34ee54536dfScope
CuratedReviewCaserecords frozen privately for later unblinding/calibration without optimizer rerun;Critical invariants
Verification
Exact HEAD:
baa7e8312ef02907e01042ab4fb6d841720e5108E9,F63,F7,F82: PASS on 3.11 + 3.12949227048044adee1ea241e9b2620c3059a5761eaeab8788c2de40a7214c41ce0285bb4cb0949226954165d8089109b87b6b700a892a8790cf21558ec0b4be26bf504ec6607d852c57cddd8f0cdb672202289530579d092cf0feb5cedf25819f6399181f4b37bb26ed8ccefb6cc0f4a9607ffaadcae932e5f7b907503cbf2cd5bfdaab36462eREADY_FOR_MERGE=YESAuthority
MERGE_AUTHORIZATION=YES — explicit user
MERGE GOOPTIMIZER_RANKING_ACTIVATION=NO
PDM_TRAINING=NO
RELEASE_AUTHORIZATION=NO
DEPLOY_AUTHORIZATION=NO
PRODUCTION_ACTIVATION=NO