root: patch to ensure GIL is held during CPython API call - #943
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports an upstream ROOT Python fix into the EIC Spack overlay so affected ROOT versions apply the GIL-related patch during concretization/build.
Changes:
- Adds an upstream ROOT PR patch for CPython API/GIL handling.
- Scopes the patch to ROOT
@6.38.02:6.40.00.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12 tasks
wdconinc
moved this to In Review
in ePIC Review Board (auto-populated; changes will be discarded)
wdconinc
moved this from In Review
to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR backports root-project/root#22402 into 6.38.02 through 6.40.00, in order to avoid failures in https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7889057.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply