Skip to content

backwards_ecal: add DIS scattered-electron analysis - #324

Merged
veprbl merged 4 commits into
masterfrom
backwards-ecal-dis
Aug 28, 2026
Merged

backwards_ecal: add DIS scattered-electron analysis#324
veprbl merged 4 commits into
masterfrom
backwards-ecal-dis

Conversation

@mandrenguyen

@mandrenguyen mandrenguyen commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

Adds a new benchmark analysis adapted for DIS events, as opposed to the previous one, which is optimized for a particle gun. Here some extra logic is necessary to select the cluster belonging to the scattered electron.
Otherwise the benchmarked quantities are the same:

  • Energy response: E_{cluster}/p_{truth}
  • Energy resolution versus truth-electron energy, using the same Crystal-Ball/FWHM convention as the particle-gun benchmark
  • Position residuals: (x_{cluster}-x_{endpoint}) and (y_{cluster}-y_{endpoint})
  • Position resolution versus truth-electron energy, using the central 68% half-width
  • Cluster-matching efficiency versus energy

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • [X ] Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [X ] New feature (issue #__)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

AI was used to reformat my pre-existing analysis code to the format expected by the benchmarking.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this is just a notebook with code to do analysis, not wired to any simulations - not a real benchmark

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Latest commit should trigger the CI I guess. I'm a bit new to this workflow. Let's see.

@veprbl veprbl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Image

Comment thread benchmarks/backwards_ecal/backwards_ecal_dis.org Outdated
@veprbl
veprbl enabled auto-merge (squash) August 26, 2026 15:06
@veprbl
veprbl disabled auto-merge August 27, 2026 14:35
@veprbl
veprbl enabled auto-merge (squash) August 27, 2026 14:35
@veprbl
veprbl merged commit d3d12bb into master Aug 28, 2026
3 checks passed
@veprbl
veprbl deleted the backwards-ecal-dis branch August 28, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants