fix: remove ROOT 6.40.02 libname/SONAME workaround - #322
Open
wdconinc wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a previously added workaround for ROOT 6.40.02 libname/SONAME issues in the lowq2_reconstruction benchmark workflow.
Changes:
- Drops ROOT environment-variable setup and
LD_PRELOADworkaround from the Snakemake rule that filters HepMC3 input. - Removes the explicit
import ROOTside-effect import fromfilterHEPMC3.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmarks/lowq2_reconstruction/Snakefile | Removes ROOT 6.40.* include/lib path exports and LD_PRELOAD workaround from the filtering rule. |
| benchmarks/lowq2_reconstruction/filterHEPMC3.py | Removes explicit import ROOT side-effect import while continuing to use pyHepMC3.rootIO. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
3
| from pyHepMC3 import HepMC3 as hm | ||
| from pyHepMC3.rootIO import HepMC3 as hmrootIO | ||
| import argparse |
veprbl
approved these changes
Aug 10, 2026
Contributor
Author
wdconinc
force-pushed
the
root-libname-soname
branch
from
August 14, 2026 19:55
3b95704 to
dd72180
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR reverts the ROOT 6.40.02 libname/SONAME workaround introduced earlier.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply