backwards ecal: add position resolution - #321
Merged
Merged
Conversation
Member
|
This ran into a problem: which might be related to the pinned versions https://github.com/eic/detector_benchmarks/blob/55968d426d6e036affb246fabf619365e5d35ab5/benchmarks/backwards_ecal/requirements.txt Which version have you used? |
Contributor
Author
|
531bfcec0f7e20e5c5dc3809c3315c1f45f9b70b should address the initial failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds an additional benchmark for the backwards ECAL which is the position residual compared to the electron endpoint. An improved version would be to instead use the truth cluster, but that would require a resolution of eic/EICrecon#2612
This quantity is the same one presented at the TIC meeting.
It occurs to me that running this benchmark on a photon gun, rather than electron gun might be preferable to avoid an effect of the magnetic field bending.
Codex was used to adapt the code format to the one expected for benchmarking.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply