lowq2_reconstruction: preload ROOT libCore for filterHEPMC3 - #320
Merged
Conversation
Add an LD_PRELOAD workaround in filter_hepmc_for_training to force resolution to libCore.so.6.40 so ROOT.modulemap is found reliably.\n\nMark this as FIXME and note the in-progress ROOT upstream bug; with a single ROOT install in our containers, this should remain harmless after upgrades away from ROOT 6.40.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize the filterHEPMC3.py step in the Low-Q2 reconstruction benchmark by forcing consistent ROOT shared-library resolution so ROOT.modulemap can be found reliably inside the container environment.
Changes:
- Preloads
libCore.so.6.40viaLD_PRELOADin thefilter_hepmc_for_trainingSnakemake rule. - Adds a FIXME note documenting that the preload is a temporary workaround for an upstream ROOT issue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
filterHEPMC3.pystep can fail to locateROOT.modulemapwhen library resolution lands on a patch-level variant instead of the expected soname. This blocks stable Low-Q2 training event filtering in the container environment.What changed
In
benchmarks/lowq2_reconstruction/Snakefile, thefilter_hepmc_for_trainingshell block now preloads:LD_PRELOAD="${LD_PRELOAD:+$LD_PRELOAD:}/opt/local/lib/root/libCore.so.6.40"This is added alongside the existing ROOT include/library path exports so resolution consistently targets the non-patch-level
.soneeded for correct modulemap discovery.Notes for reviewers
A
FIXMEcomment flags this as a temporary workaround for an in-progress ROOT upstream bug. With a single ROOT installation in these containers, keeping this preload should be low risk even as we upgrade away from ROOT 6.40.