Skip to content

chore: root-6.40.04 - #401

Open
wdconinc wants to merge 2 commits into
masterfrom
root-6.40.04
Open

chore: root-6.40.04#401
wdconinc wants to merge 2 commits into
masterfrom
root-6.40.04

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This pull request updates the ROOT package version and synchronizes the related cherry-pick hashes and documentation in the build scripts. The most important changes are:

ROOT package update:

  • Updated the required ROOT version from @6.40.02 to @6.40.04 in spack-environment/packages.yaml to ensure the environment uses the latest compatible release.

Build script synchronization:

  • Added the commit hash 8090c2e88e44621599b1e6e2a1f6243fd8ec78d3 to the list of cherry-pick hashes in spack-packages.sh to track the new ROOT version update.
  • Documented the new cherry-pick with a comment describing the addition of ROOT v6.40.04 in spack-packages.sh.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: ROOT 6.40.04)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

AI generated PR description.

Copilot AI lite review requested due to automatic review settings August 28, 2026 20:50
@wdconinc
wdconinc enabled auto-merge (squash) August 28, 2026 20:50
@wdconinc wdconinc changed the title Root 6.40.04 chore: root-6.40.04 Aug 28, 2026
@wdconinc
wdconinc disabled auto-merge August 28, 2026 20:50
@wdconinc
wdconinc enabled auto-merge (squash) August 28, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spack environment to require ROOT 6.40.04 and synchronizes the corresponding spack/spack-packages cherry-pick tracking so the new ROOT version is available during builds.

Changes:

  • Bump the ROOT requirement in spack-environment/packages.yaml from @6.40.02 to @6.40.04.
  • Add and document the spack/spack-packages cherry-pick commit 8090c2e8... that introduces ROOT v6.40.04.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
spack-packages.sh Adds the ROOT v6.40.04 cherry-pick hash and its descriptive tracking comment.
spack-environment/packages.yaml Updates the required ROOT version to @6.40.04 in the global package requirements.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wdconinc
wdconinc requested a review from a team August 28, 2026 22:07

@veprbl veprbl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Please consult capybara before merging.

@github-actions

Copy link
Copy Markdown

Capybara summary for PR 401

@wdconinc

Copy link
Copy Markdown
Contributor Author

This is good. Please consult capybara before merging.

Sufficient number for Delta == 1 comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants