fix(cicd): pin publish npm upgrade to npm@11, not @latest - #92
Merged
Conversation
the publish workflow upgrades npm to support oidc via `npm install -g npm@latest`. npm@latest drifted to npm@12, which requires node >=22.22.2, but the runner pins node via .nvmrc (v22.21.0) -> EBADENGINE -> the upgrade fails and v0.26.0 could not publish to npm. pin the upgrade to npm@11: it satisfies the >=11.5.1 oidc minimum and supports the pinned node, so a future npm major cannot drift the engine out from under the runner again. Co-authored-by: ulad kasach <uladkasach@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cicd): pin publish npm upgrade to npm@11, not @latest
the publish workflow upgrades npm to support oidc via
npm install -g npm@latest.npm@latest drifted to npm@12, which requires node >=22.22.2, but the runner pins
node via .nvmrc (v22.21.0) -> EBADENGINE -> the upgrade fails and v0.26.0 could
not publish to npm.
pin the upgrade to npm@11: it satisfies the >=11.5.1 oidc minimum and supports
the pinned node, so a future npm major cannot drift the engine out from under
the runner again.
🐢🌊 surfed in by seaturtle[bot]