fix(cicd): pin npm@11 in publish workflow to unbreak npm oidc publish - #75
Merged
Conversation
- the publish job upgrades npm to get oidc support (needs >= 11.5.1) when the
runner's npm is older, via 'npm install -g npm@latest'
- npm@latest rolled to 12.0.1, which requires node >= 22.22.2; .nvmrc pins
22.21.0, so the upgrade step EBADENGINE-failed before npm publish ran
- this blocked the v1.8.0 publish (tag + gh release cut, but npm stayed 1.7.3)
- pin to npm@11: still oidc-capable (>= 11.5.1) and compatible with node 22.21.0
.why = restore the npm publish path without a node bump; npm@latest tracking a
node-incompatible major is the root cause, so pin to the compatible major
Co-authored-by: ulad kasach <uladkasach@gmail.com>
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cicd): pin npm@11 in publish workflow to unbreak npm oidc publish
runner's npm is older, via 'npm install -g npm@latest'
22.21.0, so the upgrade step EBADENGINE-failed before npm publish ran
.why = restore the npm publish path without a node bump; npm@latest tracking a
node-incompatible major is the root cause, so pin to the compatible major
🐢🌊 surfed in by seaturtle[bot]