feat(exid): rename change 'id' to 'exid' as the natural key - #73
Merged
Conversation
- domain: ChangeDefinition.id -> ChangeDefinition.exid (ehmpathy ubiqlang natural key)
- yaml: accept both 'id' (legacy, deprecation nudge) and 'exid'; dual-read stays for backcompat
- cli: sync --id renamed to --exid (hard cut, with rename hint on the old flag)
- db: change_log column change_id -> change_exid, with an idempotent migrate sql run
during provisionChangeLogTable for both mysql and postgres
- tests: prove the atomic prod upgrade (provision once on a real legacy change_id table
lands change_exid) against both dialects; add rule.require.both-dialects-tested
.why = 'id' is reserved for artificial primary keys; 'exid' is the established ehmpathy
term for a human-authored natural key, which disambiguates intent for the longhaul
Co-authored-by: ulad kasach <uladkasach@gmail.com>
- .agent/keyrack.yml re-added ghlitch observer+operator extends via env drift
- ghlitch/operator declares AWS_PROFILE as strictly required under env.all
- jest.acceptance.env.ts sources .agent/keyrack.yml in strict mode, so ci
(which has no aws creds) exit-2'd before any acceptance test ran
- this library's acceptance suite needs no aws ops creds; revert keyrack.yml
to main's 3-extends set
.why = the aws ops-role credential requirement does not belong in this repo's
acceptance credential set; it was unrelated tooling drift
Co-authored-by: ulad kasach <uladkasach@gmail.com>
…nce ci
- package.json + pnpm-lock bumped rhachet-roles-ehmpathy 1.35.15 -> 1.38.1
(plus new ghlitch/bhrowser/rhachet role packages) via env drift
- the 1.38.1 mechanic role keyrack now declares AWS_PROFILE strictly required;
jest.acceptance.env.ts sources .agent/keyrack.yml strict, so ci (no aws creds)
exit-2'd before any acceptance test ran
- revert package.json, pnpm-lock, .depcheckrc.yml, .claude/settings.json,
.agent/keyrack.yml to main; all five are now byte-identical to main
- leaves this branch as purely the exid feature
.why = the rhachet role-tooling upgrade is unrelated to the exid rename and was
breaking acceptance ci; it belongs in its own change, not this pr
Co-authored-by: ulad kasach <uladkasach@gmail.com>
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(exid): rename change 'id' to 'exid' as the natural key
during provisionChangeLogTable for both mysql and postgres
lands change_exid) against both dialects; add rule.require.both-dialects-tested
.why = 'id' is reserved for artificial primary keys; 'exid' is the established ehmpathy
term for a human-authored natural key, which disambiguates intent for the longhaul
🐢🌊 surfed in by seaturtle[bot]