Repository navigation
Fix Suno media credential scoping and partial audio reporting - #38
Merged
Merged
Conversation
Pull Request Summary by devActivityMetricsAchievements
|
3 of 44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real capture retrieved 36 clip records and 72 artwork files but every primary audio request returned HTTP 403. The CLI still displayed “Capture Complete” and verification PASS. This change fixes two confirmed client/reporting defects and adds a safe way to investigate the remaining live provider rejection.
mindcap inspect suno "<existing-version-directory>" --asset-diagnostics: an offline, count-only JSON report that classifies saved primary links, including Suno's/api/forbiddenplaceholder and signature-parameter presence. It reads verified canonical metadata, prints no titles/IDs/hosts/URLs/credentials and works with old captures. Regression coverage includes malformed input and unchecked metadata substitution.--no-include-videounbound-local crash. Remove pre-existing formatter-only blank lines in the vault catalog and normalize a touched CLI string so repository formatter gates pass; no vault behavior changes.Limits: These fixes do not establish the cause of the maintainer's live 403s. The adapter still consumes URLs from clip metadata and does not add a new provider download-authorization/allowance flow. We need the new offline diagnostics and/or the site's own Download result to distinguish a forbidden placeholder, expired/denied CDN link or account eligibility. No actual credentials/browser state were accessed, no real media was downloaded, and no quota-consuming export request was made. Existing
--audio-formatonly changes the extension; WAV/stem export negotiation is not implemented by Suno capture.Validation on exact tree
765b63b933e7f506ce4b11086792c1eaf276e127: 527 tests passed; Ruff lint and format checks passed with both uv-lock 0.15.22 and Poetry-lock 0.16.0 versions; focused strict Mypy passed 12 files; wheel and sdist built. A fresh wheel installation, run outside the checkout, inspected a synthetic old-style 36-clip capture and emitted only the expected safe counts. Mock transports exercise authenticated API metadata, credential-rejecting CDNs, signed queries, same/cross-origin redirects, temp cleanup, all/individual asset failures, complete captures, partial archive integrity and machine-readable CLI output. Full-repository Mypy has the exact same 28 pre-existing diagnostics in nine files as main. Offline tests clear this environment's inherited SOCKS proxy, as with #37; runtime dependencies and lockfiles are unchanged.This PR is independent of bookmark PR #37 and does not modify the roadmap or attempt ADR backfill.
GitHub Actions CI run 39128879922 passed on head
e804974d10c75c1d9080e31ea1b14e4285079392: Poetry configuration/install, formatting, lint, full tests, architecture boundaries, wheel/sdist build, required package contents and clean-tree checks. Independent review closed its findings and reran inspector/pipeline coverage: 31 passed.