Repository navigation
fix: desktop session dashboard 3-column layout collapsing to zero height - #70
Merged
Merged
Conversation
…ero height IntrinsicHeight wrapping a Row whose children were Expanded + SingleChildScrollView (itself nested inside the page's own SingleChildScrollView) gave every column unbounded/conflicting height constraints. On the web renderer this collapsed Jogadores/NPCs/Log to zero height, leaving only the sidebar and session card visible - no error surfaced in the UI since Flutter contains layout failures to the affected subtree. Removed IntrinsicHeight and the per-column SingleChildScrollView; the columns now size to their natural content height and scroll along with the rest of the page via the single outer SingleChildScrollView. Also added a takeException() check to the desktop layout test, since find.text() alone doesn't detect a RenderObject that built fine but failed to lay out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
No layout desktop (Story 11.2/11.4),
IntrinsicHeightenvolvendo umRowcujos filhos eramExpanded+SingleChildScrollView(por sua vez dentro de outroSingleChildScrollViewda própria página) dava a cada coluna constraints de altura conflitantes/ilimitadas. Isso colapsava as colunas Jogadores/NPCs/Log para altura zero no Web, deixando só a sidebar e o card de sessão visíveis — sem erro aparente na UI.Removido o
IntrinsicHeighte oSingleChildScrollViewpor coluna; as colunas agora têm altura natural e rolam junto com o resto da página pelo únicoSingleChildScrollViewexterno.Test plan
flutter analyzesem issuesflutter test(135/135)dart format --set-exit-if-changed .sem mudanças