perf(agent-runtime): skip thinking token progress persistence - #465
perf(agent-runtime): skip thinking token progress persistence#465jerryliang64 wants to merge 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
system/thinking_tokensprogress counters from thread message persistence/runs/streamand run-event replaythinkingcontentMessageConverterandAgentRuntimeintegration levelsRoot cause
After a run commits, the incremental message flusher attempts to mirror every executor message into the thread store.
thinking_tokensis emitted frequently as a progress counter, so persisting it creates one awaited remote append per update on OSS/FUSE-backed stores and backpressures consumption of subsequent model events.The counter is transient metadata rather than conversation history. Filtering it at the existing storage boundary removes that write amplification without changing the streaming protocol or final transcript.
Validation
core/agent-runtime:ut run test(210 passing)core/agent-runtime:ut run tsccore/agent-runtime:ut run tsc:pubut run lint