feat(mcp): support UI metadata for tool registration - #463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughMCP tool definitions now support optional UI metadata. ChangesMCP metadata propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant MCPTool
participant MCPToolMeta
participant MCPServerHelper
participant MCPClient
MCPTool->>MCPToolMeta: define meta.ui metadata
MCPToolMeta->>MCPServerHelper: retain toolMeta.meta
MCPServerHelper->>MCPClient: registerTool with _meta
MCPClient->>MCPClient: listTools returns _meta
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
core/controller-decorator/src/model/MCPToolMeta.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. core/controller-decorator/test/MCPMeta.test.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. core/controller-decorator/test/fixtures/MCPController.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces support for metadata configuration in MCP tools by adding a meta property to MCPToolParams and propagating it during tool registration in both the controller plugin and standalone service worker. The review feedback suggests improving the extensibility of MCPToolRegistrationMeta by making the ui property optional and allowing arbitrary key-value pairs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
8b44c7a to
b62d634
Compare
b62d634 to
73eb7d3
Compare
Summary
meta.uiconfiguration toMCPToolmetaand map it to MCP SDK_metaduring tool registrationTesting
tsc:pubfor tegg-types, controller-decorator, controller plugin, and service workernpm run lintSummary by CodeRabbit
New Features
resourceUriandvisibility(limited to model/app).Tests
resourceUriandvisibility).