Skip to content

Assets: logos extract again - #10

Merged
efficiencyx merged 1 commit into
efficiencyx:mainfrom
runnevia-ryn:fix-logo-extraction
Nov 10, 2026
Merged

efficiencyx merged 1 commit into
efficiencyx:mainfrom
runnevia-ryn:fix-logo-extraction

Conversation

@runnevia-ryn

Copy link
Copy Markdown
Collaborator

Summary

tools/recover_assets.py defined DECALS twice. The second dict, the makeup and accessory sheets added in v1.3.0, replaced the logo map, so recover_logos() looped over the makeup keys and skipped every logo. The sheets dict is now DECAL_SHEETS, and recover_decals() uses it. The logo map is unchanged.

Why

Any fresh extraction on v1.3.0 or later gets no webapp/assets/variants/logos folder. Shirt, hoodie and panties logos then show the LOGO placeholder in the wardrobe, including the logos the bridge brings over from the game, such as Monizmed on hoodie 17107. The extraction log shows SKIP logos/eyeshadow, SKIP logos/manicure and so on, and ends with WARNING: 17 item(s) not found.

Installs extracted on v1.2.0 still have the old logos folder, and updates don't re-extract, so it only shows up on newer extractions.

Validation

  • I ran targeted syntax or automated checks for the files I changed.

  • I exercised the affected behavior directly where practical.

  • I checked the relevant service or browser logs.

  • python -m py_compile tools/recover_assets.py in the asset-recovery venv on Windows 10: passed.

  • Extraction from game 0.97.12 into a separate --out folder: 68 of 68 logos written, no SKIP logos/... lines and no warning. variants/decals still has its 17 sheets plus mapping.json.

  • Re-extracted into my install and hard-refreshed: the hoodie shows Monizmed instead of the placeholder, and the logo pickers show their thumbnails.

  • Not run: extraction on Linux or Docker through install.sh. It runs the same script, so it should get the same fix.

Platforms affected

Asset extraction on every platform, since install.ps1 and install.sh both run tools/recover_assets.py. Existing installs need a re-extraction (JUN_EXTRACT=1) to get the logos.

Checklist

  • The change is focused and preserves existing APIs and configuration unless documented otherwise.
  • I updated documentation and .env.example when behavior or configuration changed. (No behavior or configuration changed.)
  • I did not include secrets, private chat data, model weights, or extracted/recovered game assets.
  • Frontend changes remain dependency-free ES modules and use consistent ?v= cache-busters. (No frontend changes.)
  • For changes under webapp/, I ran ./sync-webapp.sh (-s only for static files) and hard-refreshed, or explained above why I could not. (No changes under webapp/.)
  • Streaming changes handle markers split across arbitrary chunks and do not expose hidden action or bookkeeping tags. (Not applicable.)
  • Prompt changes preserve prefix stability and keep dynamic context after the user's question, unless the PR explicitly explains why that invariant changes. (Not applicable.)

Screenshots or recordings

None. A screenshot would show recovered game art.

…ogo DECALS map

v1.3.0 added a second DECALS dict for the makeup and accessory sheets. It replaced the logo map, so recover_logos() looped over the makeup keys and every logo was skipped. Fresh extractions on v1.3.0 and later got no variants/logos folder, and the wardrobe showed the LOGO placeholder. The sheets dict is now DECAL_SHEETS.
@efficiencyx
efficiencyx merged commit 0292e49 into efficiencyx:main Nov 10, 2026
8 checks passed
efficiencyx added a commit that referenced this pull request Nov 10, 2026
…ompts and download progress, logo extraction fix (#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants