Repository navigation
Assets: logos extract again - #10
Merged
Merged
Conversation
…ogo DECALS map v1.3.0 added a second DECALS dict for the makeup and accessory sheets. It replaced the logo map, so recover_logos() looped over the makeup keys and every logo was skipped. Fresh extractions on v1.3.0 and later got no variants/logos folder, and the wardrobe showed the LOGO placeholder. The sheets dict is now DECAL_SHEETS.
efficiencyx
added a commit
that referenced
this pull request
Nov 10, 2026
…ompts and download progress, logo extraction fix (#10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/recover_assets.pydefinedDECALStwice. The second dict, the makeup and accessory sheets added in v1.3.0, replaced the logo map, sorecover_logos()looped over the makeup keys and skipped every logo. The sheets dict is nowDECAL_SHEETS, andrecover_decals()uses it. The logo map is unchanged.Why
Any fresh extraction on v1.3.0 or later gets no
webapp/assets/variants/logosfolder. Shirt, hoodie and panties logos then show theLOGOplaceholder in the wardrobe, including the logos the bridge brings over from the game, such as Monizmed on hoodie 17107. The extraction log showsSKIP logos/eyeshadow,SKIP logos/manicureand so on, and ends withWARNING: 17 item(s) not found.Installs extracted on v1.2.0 still have the old logos folder, and updates don't re-extract, so it only shows up on newer extractions.
Validation
I ran targeted syntax or automated checks for the files I changed.
I exercised the affected behavior directly where practical.
I checked the relevant service or browser logs.
python -m py_compile tools/recover_assets.pyin the asset-recovery venv on Windows 10: passed.Extraction from game 0.97.12 into a separate
--outfolder: 68 of 68 logos written, noSKIP logos/...lines and no warning.variants/decalsstill has its 17 sheets plusmapping.json.Re-extracted into my install and hard-refreshed: the hoodie shows Monizmed instead of the placeholder, and the logo pickers show their thumbnails.
Not run: extraction on Linux or Docker through
install.sh. It runs the same script, so it should get the same fix.Platforms affected
Asset extraction on every platform, since
install.ps1andinstall.shboth runtools/recover_assets.py. Existing installs need a re-extraction (JUN_EXTRACT=1) to get the logos.Checklist
.env.examplewhen behavior or configuration changed. (No behavior or configuration changed.)?v=cache-busters. (No frontend changes.)webapp/, I ran./sync-webapp.sh(-sonly for static files) and hard-refreshed, or explained above why I could not. (No changes underwebapp/.)Screenshots or recordings
None. A screenshot would show recovered game art.