304589 delete data on replace - #320
Open
michailpanagiotou wants to merge 5 commits into
Open
Conversation
… the needed records exist in dataset_value and table_value. If not it adds them Refs #295327
…ional's ability to rollback Refs #295327
Bug 295327 perm fix attachment field issue
…ndow' into MasterDataLakes
apboutos-trasys
requested changes
Jul 28, 2026
apboutos-trasys
left a comment
apboutos-trasys
left a comment
There was a problem hiding this comment.
A few null cases to be handled at the beginnning. I can see no other problem in the review face. Needs to be tested.
| for(int i=0; i < numberOfRetriesForJobPolling; i++) { | ||
| DremioJobStatusResponse response = this.pollForJobStatus(processId); | ||
| String jobState = response.getJobState().getValue(); | ||
| if(jobState.equals(DremioJobStatusEnum.COMPLETED.getValue())) { |
There was a problem hiding this comment.
jobState.equals(DremioJobStatusEnum.COMPLETED.getValue()) will throw NullPointerException if jobstate is
use equals on the static string value instead DremioJobStatusEnum.COMPLETED.getValue().equals(jobstate)
| processIsFinished = true; | ||
| break; | ||
| } | ||
| else if(jobState.equals(DremioJobStatusEnum.CANCELED.getValue()) || jobState.equals(DremioJobStatusEnum.FAILED.getValue())){ |
| Boolean processIsFinished = false; | ||
| for(int i=0; i < numberOfRetriesForJobPolling; i++) { | ||
| DremioJobStatusResponse response = this.pollForJobStatus(processId); | ||
| String jobState = response.getJobState().getValue(); |
There was a problem hiding this comment.
If the response or the JobState is null this will produce a NullPointerException that will break your for loop. The retry mechanism is meaningless in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.