ci(e2e): a red badge should mean the tests failed - #36
Merged
Merged
Conversation
`playwright install --with-deps` runs `apt-get update` over every repo the runner image has configured, Google's Chrome repo included. We do not use it — Playwright downloads its own chromium — but when it published a bad index today (`Hash Sum mismatch` on dl.google.com/linux/chrome-stable/deb) the whole install exited 100 and took this job down four times, on branches that had not touched a line of UI code. The repo is public and the README carries this workflow's badge, so a red E2E during judging is a claim about our tests. It should not be able to mean "Google was mid-publish". Drop the repo we do not need, and retry once for an ordinary transient.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The first attempt removed /etc/apt/sources.list.d/google-chrome.list and the job failed identically: the runner image does not always name it that. Match on dl.google.com instead, across whatever file declares it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playwright install --with-depsrunsapt-get updateacross every apt repo on the runner, including Google's Chrome repo. We never use it — Playwright downloads its own chromium build.Today that repo served a bad index and the job died four times in a row with
E: Failed to fetch .../chrome-stable/deb/... Hash Sum mismatch→Installation process exited with code: 100, on branches with no UI changes. The tests never ran.The README badge points at this workflow on
main, and the repo is public during judging, so red has to mean the tests failed. Removes the unused apt source and retries once.