Skip to content

Proper CMake tree - #10

Merged
edimarvalentin merged 3 commits into
mainfrom
refactor-cmake
Aug 30, 2025
Merged

Proper CMake tree #10
edimarvalentin merged 3 commits into
mainfrom
refactor-cmake

Conversation

@edimarvalentin

Copy link
Copy Markdown
Owner

This pull request refactors the CMake build and test configuration to improve modularity and maintainability. The main change is moving test setup logic for dense_mread and sparse_mread into their own subdirectories, simplifying the root CMakeLists.txt and making test management more organized. Additionally, the GitHub Actions workflow is updated to run tests from the correct directory.

CMake configuration refactoring:

  • Moved test configuration for dense_mread and sparse_mread out of the root CMakeLists.txt and into separate CMakeLists.txt files within their respective subdirectories, cleaning up the main build file and improving modularity. [1] [2] [3] [4]
  • Added a new test/CMakeLists.txt to enable testing and include the dense_mread and sparse_mread subdirectories, centralizing test setup.

CI workflow update:

  • Changed the working directory for the test step in .github/workflows/cmake-single-platform.yml to build/test, ensuring tests are executed from the correct location after the new test structure.

@edimarvalentin edimarvalentin self-assigned this Aug 28, 2025
@edimarvalentin edimarvalentin added the enhancement New feature or request label Aug 28, 2025
@edimarvalentin edimarvalentin linked an issue Aug 30, 2025 that may be closed by this pull request
@edimarvalentin
edimarvalentin marked this pull request as ready for review August 30, 2025 20:38
@edimarvalentin
edimarvalentin requested a review from Copilot August 30, 2025 20:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CMake build system to improve modularity by moving test configurations into their own subdirectories. The change separates test setup logic from the main CMakeLists.txt file, creating a more organized and maintainable project structure.

  • Moved test configuration for dense_mread and sparse_mread out of root CMakeLists.txt into dedicated subdirectory CMakeLists.txt files
  • Created a centralized test/CMakeLists.txt to manage test subdirectories
  • Updated GitHub Actions workflow to run tests from the correct build directory

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CMakeLists.txt Removed all test configuration logic and added test subdirectory inclusion
test/CMakeLists.txt Added centralized test configuration with enable_testing() and subdirectory includes
test/dense_mread/CMakeLists.txt Created dedicated CMake configuration for dense_mread test
test/sparse_mread/CMakeLists.txt Created dedicated CMake configuration for sparse_mread test
.github/workflows/cmake-single-platform.yml Updated test working directory to build/test

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/dense_mread/CMakeLists.txt Outdated
Comment thread test/sparse_mread/CMakeLists.txt Outdated
edimarvalentin and others added 2 commits August 30, 2025 13:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@edimarvalentin
edimarvalentin merged commit 11a05cc into main Aug 30, 2025
1 check passed
@edimarvalentin
edimarvalentin deleted the refactor-cmake branch August 30, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake structure improvement

2 participants