Proper CMake tree - #10
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CMake build system to improve modularity by moving test configurations into their own subdirectories. The change separates test setup logic from the main CMakeLists.txt file, creating a more organized and maintainable project structure.
- Moved test configuration for
dense_mreadandsparse_mreadout of root CMakeLists.txt into dedicated subdirectory CMakeLists.txt files - Created a centralized test/CMakeLists.txt to manage test subdirectories
- Updated GitHub Actions workflow to run tests from the correct build directory
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Removed all test configuration logic and added test subdirectory inclusion |
| test/CMakeLists.txt | Added centralized test configuration with enable_testing() and subdirectory includes |
| test/dense_mread/CMakeLists.txt | Created dedicated CMake configuration for dense_mread test |
| test/sparse_mread/CMakeLists.txt | Created dedicated CMake configuration for sparse_mread test |
| .github/workflows/cmake-single-platform.yml | Updated test working directory to build/test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the CMake build and test configuration to improve modularity and maintainability. The main change is moving test setup logic for
dense_mreadandsparse_mreadinto their own subdirectories, simplifying the rootCMakeLists.txtand making test management more organized. Additionally, the GitHub Actions workflow is updated to run tests from the correct directory.CMake configuration refactoring:
dense_mreadandsparse_mreadout of the rootCMakeLists.txtand into separateCMakeLists.txtfiles within their respective subdirectories, cleaning up the main build file and improving modularity. [1] [2] [3] [4]test/CMakeLists.txtto enable testing and include thedense_mreadandsparse_mreadsubdirectories, centralizing test setup.CI workflow update:
.github/workflows/cmake-single-platform.ymltobuild/test, ensuring tests are executed from the correct location after the new test structure.