feat: #IMPULS-6059 add service to add push notif to push manager and modified quiet hours push notif handling - #1121
Merged
vbillard91 merged 4 commits intoAug 31, 2026
Conversation
…modified quiet hours push notif handling
jcbe-ode
reviewed
Aug 27, 2026
…ultPushNotifService.java Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com>
jcbe-ode
reviewed
Aug 28, 2026
jcbe-ode
left a comment
jcbe-ode
left a comment
Contributor
There was a problem hiding this comment.
Commentaire à ajouter ou code à refacto ? Voir ce qui te semble le plus judicieux.
Contributor
Author
|
jcbe-ode
reviewed
Aug 28, 2026
jcbe-ode
left a comment
jcbe-ode
left a comment
Contributor
There was a problem hiding this comment.
1 fichier a été ajouté par erreur à priori,
sinon c'est tout bon pour moi !
|
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Sep 1, 2026
…modified quiet hours push notif handling (#1121) * feat: #IMPULS-6059 add service to add push notif to push manager and modified quiet hours push notif handling * Update timeline/src/main/java/org/entcore/timeline/services/impl/DefaultPushNotifService.java Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com> * PR review * rollback package.json --------- Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com>
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Sep 1, 2026
…modified quiet hours push notif handling (#1121) * feat: #IMPULS-6059 add service to add push notif to push manager and modified quiet hours push notif handling * Update timeline/src/main/java/org/entcore/timeline/services/impl/DefaultPushNotifService.java Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com> * PR review * rollback package.json --------- Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify in timeline quiet hours handlign for push notif, to use new push manager module instead of dropping push notifs in quiet hours
Fixes
https://edifice-community.atlassian.net/browse/IMPULS-6059
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃