fix(react): #ENABLING-1119 casse l'import circulaire AddAttachments/SingleAttachment - #565
Open
pascalsaussier-edifice wants to merge 1 commit into
Open
Conversation
pascalsaussier-edifice
requested review from
damienromito,
david-cc and
jcbe-ode
August 12, 2026 12:12
jcbe-ode
previously approved these changes
Aug 13, 2026
damienromito
previously approved these changes
Aug 24, 2026
pascalsaussier-edifice
dismissed stale reviews from damienromito and jcbe-ode
August 25, 2026 15:19
The merge-base changed after approval.
pascalsaussier-edifice
force-pushed
the
develop-enabling
branch
from
August 25, 2026 15:19
2b0b45c to
590c081
Compare
…ingleAttachment Les imports via barrels ancêtres (src/index.ts, src/components/index.ts) laissent des bindings undefined quand le graphe de modules est encore en cours d'évaluation à l'entrée par AddAttachments, sous Vitest. Remplacés par des chemins relatifs directs vers Attachment, IconButton, Button, Modal et Tooltip.
pascalsaussier-edifice
force-pushed
the
fix-ENABLING-1119-circular-import-attachments
branch
from
August 26, 2026 15:13
d95aeb7 to
3863948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrige un import circulaire qui empêche
AddAttachmentsd'être rendu quand il est importé directement (hors barrel), notamment sous Vitest : le rendu plantait avecElement type is invalid ... got: undefinedau niveau deSingleAttachment.Cause : plusieurs composants du sous-arbre
AddAttachmentsimportaientAttachment,IconButton,Button,ModaletTooltipvia des barrels ancêtres (src/index.ts,src/components/index.ts), encore en cours d'évaluation quand l'entrée se fait parAddAttachments. Remplacés par des imports relatifs directs vers les fichiers sources — aucun changement de comportement fonctionnel.Ticket : ENABLING-1119
Which Package changed?
Has the documentation changed?
Type of change
Checklist:
Comment tester
pnpm test --filter=./packages/react— passe intégralement (252 fichiers / 2425 tests), incluant le nouveauAddAttachments.spec.tsxqui couvre editMode (ajout/suppression), téléchargement et copie vers l'espace.pnpm --filter @edifice.io/react build— build/déclarations de types OK.AddAttachments.stories.tsxen Storybook — inchangé, pas de régression visuelle attendue (chemins d'import seulement).