feat: adds bottomsheet functionality to albumpage - #922
Open
andOrlando wants to merge 1 commit into
Open
Conversation
adds items to album_page_menu.xml: - Instant mix - Play Next - Add to Queue and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_ I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #920
adds items to album_page_menu.xml:
and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment
strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_
I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet
It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages
before:
after:
