Repository navigation
Resolve PLAN.md review items - #190
Open
AidinTeymouri wants to merge 4 commits into
Open
AidinTeymouri wants to merge 4 commits into
AidinTeymouri wants to merge 4 commits into
Conversation
Define API response shapes, trading rules, chat/mock LLM contract, SSE payload format, DB concurrency, and simplified Docker/test setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Auto-add to watchlist on buys only; sells never re-add (B1) - Define trade execution order; auto-add persists on failure (B2) - Re-fetch watchlist after every trade and chat response (B3) - Pass LLM_MOCK through compose; document E2E run commands (B4) - Require async litellm.acompletion with a timeout, mapped to 502 (B5) - Make .env optional in compose (required: false) (B6) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move hooks/ to the plugin root so it loads, and add a 120s timeout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the spec only (
planning/PLAN.md); no application code changes.BEGIN IMMEDIATEtransaction, snapshot, untrack. The auto-add persists even if the trade fails.GET /api/watchlistafter every trade and every chat response.LLM_MOCKthrough, and §13 documents the E2E run commands (down -v, thenLLM_MOCK=true docker compose up).await litellm.acompletion(..., timeout=30); any failure returns 502..envis optional in compose (required: false, Compose ≥ 2.24).Minor review items (B7–B19) are not addressed here and can be handled during implementation.
🤖 Generated with Claude Code