feat(eco-token): add TransferFromEvent for delegated transfers - #16
Merged
cybermax4200 merged 1 commit intoJul 13, 2026
Merged
Conversation
Add a distinct TransferFromEvent with from, to, spender, and amount fields, emitted in transfer_from instead of the generic TransferEvent. This lets observers distinguish delegated transfers from direct ones, aligning with SEP-0041 recommendations. Closes ecotask-network#5
NnamdiCyber
force-pushed
the
feat/transfer-from-event
branch
from
July 13, 2026 12:43
c57f1d4 to
684c64a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
transfer_fromintoken.rsperformed a delegated token transfer but emitted the sameTransferEvent { from, to, amount }as directtransfer()calls. External observers had no way to distinguish delegated transfers from direct ones.Changes
token.rs:33-42):TransferFromEventwithfrom,to,spenderas#[topic]fields andamountas datatoken.rs:269-275):transfer_fromnow emitsTransferFromEventinstead ofTransferEventtoken.rs:585-624):test_transfer_from_emits_eventverifies the correct event structure is publishedVerification
cargo clippyclean (zero warnings)Closes #5