Conversation
dsarmany
requested review from
MircoValentiniECMWF and
tweska
and
a lite review from Copilot
September 14, 2026 16:43
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reviewed changes introduce metadata classification errors and remove required encoding transformations.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request ports 2.10.x changes for surface-level classification and MTG2 encoding.
Changes:
- Updates surface-level classification in two Fortran modules.
- Removes local Mars-to-Mars mappings and payload scaling from MTG2 encoding.
File summaries
| File | Review findings |
|---|---|
src/multiom/ifs2mars/ifs-interface/ifs_utils_mod.F90 |
Moderate (3 votes): Nonzero surface levels are classified as SOL, incorrectly affecting height-above-ground products such as 2-metre temperature. |
src/multiom/core/common/enumerators_mod.F90 |
Moderate (3 votes): The nonzero-level check converts unspecified-level sfc filters and ordinary sfc/2 fields to SOL. |
src/multio/action/encode-mtg2/EncodeMtg2.cc |
Critical (2 votes): Removing allRules() drops required parameter mappings and payload scaling before encoding. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| // Apply mappings | ||
| fake_double_loop::fakeDoubleLoop(marsRec); |
Comment on lines
+1491
to
+1495
| IF ( LEVEL .NE. 0 ) THEN | ||
| ILEVTYPE = LEVTYPE_SOL_E | ||
| ELSE | ||
| ILEVTYPE = LEVTYPE_SFC_E | ||
| ! END IF | ||
| ! CASE DEFAULT | ||
| ! ILEVTYPE = LEVTYPE_SFC_E | ||
| ! END SELECT | ||
| END IF |
Comment on lines
+358
to
+362
| IF ( LEVEL .NE. 0 ) THEN | ||
| ILEVTYPE = LEVTYPE_SOL_E | ||
| ELSE | ||
| ILEVTYPE = LEVTYPE_SFC_E | ||
| END SELECT | ||
| END IF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-297