Skip to content

Add SFC -> SOL mapping for fields with non-zero levelist to IFS2MARS - #296

Open
tweska wants to merge 2 commits into
developfrom
fix/sfc-to-sol-mapping-in-ifs2mars
Open

tweska wants to merge 2 commits into
developfrom
fix/sfc-to-sol-mapping-in-ifs2mars

Conversation

@tweska

@tweska tweska commented Sep 10, 2026

Copy link
Copy Markdown
Member
  • Maps all fields with levtype = sfc and levelist != 0 to levtype = sol in IFS2MARS before it enters the Multio pipeline.
  • Removes call to legacy MARS2MARS from encode action. MARS2MARS should not be used by models to fix their metadata.

This PR addresses the same problem as #294 more general and at an earlier point in the pipeline.

Note: these changes are also in hotfix/2.10.4

@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.01%. Comparing base (bcfe78e) to head (86d19ea).

Files with missing lines Patch % Lines
src/multiom/core/common/enumerators_mod.F90 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #296      +/-   ##
===========================================
- Coverage    33.02%   33.01%   -0.02%     
===========================================
  Files          409      409              
  Lines        43448    43440       -8     
  Branches      1978     1976       -2     
===========================================
- Hits         14348    14341       -7     
+ Misses       29100    29099       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tweska
tweska marked this pull request as ready for review September 11, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants