Skip to content

Release 5.17.0#339

Draft
marcosbento wants to merge 99 commits into
mainfrom
release/5.17.0
Draft

Release 5.17.0#339
marcosbento wants to merge 99 commits into
mainfrom
release/5.17.0

Conversation

@marcosbento
Copy link
Copy Markdown
Collaborator

@marcosbento marcosbento commented May 20, 2026

Description

As per PR title

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-339

This allows the use of these constants by the inline functions defined below.
- Remove unnecessary Std/Boost dependencies
- Improve documentation and set of test cases
For unclear reasons replaceall is an alias to replace_all function, and
thus unnecessary. These changes replace replaceall with the more aptly
named replace_all, and completely remove replaceall.

Also, adds documentation and makes use of clear names for the parameters.

Re ECFLOW-2076
Also, add documentation and tests to cover the functionality.

Re ECFLOW-2076
Add documentation to all functions, and increase the functional tests.

This effectively removes all uses of boost/algorithm/string.

Re ECFLOW-2076
marcosbento and others added 6 commits May 19, 2026 12:42
Move the Process handling capabilities and the Provisioning of test
artifacts (test files, directories, environment variables) into
a single ecflow/test/scaffold support library.
The additional tests ensure the correct handling the CLI options,
along with the environment variables that can also be used to configure
the ecflow_udp server.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

❌ Patch coverage is 86.26534% with 235 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.88%. Comparing base (cb5f79b) to head (8f589c5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libs/attribute/src/ecflow/attribute/RepeatAttr.cpp 76.47% 36 Missing ⚠️
libs/core/test/TestStr.cpp 87.00% 36 Missing ⚠️
Viewer/ecflowUI/src/VRepeatAttr.cpp 0.00% 31 Missing ⚠️
Viewer/ecflowUI/src/VNode.cpp 0.00% 19 Missing ⚠️
Viewer/ecflowUI/src/VServerSettings.cpp 0.00% 10 Missing ⚠️
libs/core/test/TestLog.cpp 0.00% 9 Missing ⚠️
Viewer/libViewer/src/DirectoryHandler.cpp 0.00% 7 Missing ⚠️
Viewer/ecflowUI/src/ServerList.cpp 0.00% 6 Missing ⚠️
Viewer/ecflowUI/src/VariableModelData.cpp 0.00% 6 Missing ⚠️
Viewer/ecflowUI/src/ServerHandler.cpp 0.00% 4 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   49.68%   50.88%   +1.19%     
==========================================
  Files        1237     1239       +2     
  Lines       97636    99249    +1613     
  Branches    14829    14957     +128     
==========================================
+ Hits        48507    50499    +1992     
+ Misses      49129    48750     -379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Related to Boost >= 106600 && < 108600
Depending on the underlying Repeat type, the current_value will
return either a Python str or int.

Re ECFLOW-2084
- Fix documentation issues
- Avoid free standing functions in global namespace
- Log name for all tests
- Remove redundant trailing semicolons
- Remove duplicate binding for Repeat.current_value
- Ensure compile-time specialisation of current_value_of

Re ECFLOW-2084
The large amount of updated files is due to the migration from
Boost.python to pybind11, but in practice there were no API changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants