Remove protobuf generated types from public API#328
Open
sophokles73 wants to merge 1 commit into
Open
Conversation
sophokles73
force-pushed
the
remove_protobuf_types_from_public_api
branch
from
78ace46 to
908c0d6
Compare
Replaced all types that are generated by the protobuf compiler with custom types that do not depend on the protobuf crate. This reduces the public API surface and avoids leaking implementation details. Also added (Try)From implementations to convert between the protobuf generated types and the custom types.
sophokles73
force-pushed
the
remove_protobuf_types_from_public_api
branch
from
908c0d6 to
50b432d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced all types that are generated by the protobuf compiler with custom types that do not depend on the protobuf crate. This reduces the public API surface and avoids leaking implementation details.
Also added (Try)From implementations to convert between the protobuf generated types and the custom types.