session.h: Support building with LwIP, but LWIP_IPV4 or LWIP_IPV6 not set#264
Merged
Conversation
Contributor
Author
|
Just done a re-validate of eclipsefdn/eca. |
Contributor
"There is a valid ECA on file for supjps-libcoap ..." Works now. LGTM. |
Contributor
|
Please a fast go :-). |
obgm
reviewed
Nov 19, 2025
obgm
left a comment
obgm
left a comment
Contributor
There was a problem hiding this comment.
I am not really fond of using non-standard types like u8_t and u32_t instead of the standard types. As this seems to be for LWIP only, I can live with that.
Add in a dummy struct sockaddr_in or sockaddr_in6 as appropriate as would be defined in LwIP. Signed-off-by: Jon Shallow <supjps-libcoap@jpshallow.com>
mrdeep1
force-pushed
the
lwip_no_ipv6
branch
from
f24a6a8 to
f4b0073
Compare
mrdeep1
changed the title
Contributor
Author
|
Added in dummy struct sockaddr_in if LWIP_IPV4 not set. |
obgm
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in a dummy struct sockaddr_in6.