Repository navigation
Added ARMv7-A TX_THREAD offset checks - #800
JeewoongKim wants to merge 1 commit into
Conversation
The ARMv7-A assembly uses hard-coded offsets to access TX_THREAD members. Changes to the structure layout could break these accesses. Added compile-time checks in the shared ARMv7-A source tree and regenerated the GNU and AC6 port copies. Built all seven GNU port and verified that an incorrect VFP offset causes a compilation failure. Assisted-by: ChatGPT (GPT-5.6 Sol)
fdesbiens
left a comment
fdesbiens
left a comment
There was a problem hiding this comment.
Hi @JeewoongKim. Thank you for this contribution. The assertions cover the hard-coded offsets I checked in the ARMv7-A assembly, and the reported GNU builds include a useful negative check. Could you resolve the commit’s Assisted-by trailer with the maintainer so it has the accepted format and an email address, and remove the AI-process paragraphs from the PR description? The stated AC6 build limitation is clear.
|
Thanks for the review! I've removed the AI-process paragraphs from the PR description. For the |
This branch has not been deployed
2 participants
Addresses the ARMv7-A portion of #577.
The ARMv7-A assembly uses hard-coded offsets to access
TX_THREADmembers.This change adds compile-time checks to catch mismatches when the structure layout changes.
The checker is added to shared ARMv7-A source tree and propagated to all seven Cortex-A
GNU and AC6 ports using
update.sh. The GNU CMake files are also updated to compile it.I built all seven GNU ports A{5, 7, 8, 9, 12, 15, 17} and confirmed that an incorrect VFP offset
(148 instead of 144) causes a compilation failure. The AC6 ports were not built.
PR checklist