Skip to content

Change detection in footnotes between main and compare plannings#2513

Merged
TruongQuangSB merged 11 commits into
mainfrom
change-detection-in-footnotes-of-compare-planning
Jul 8, 2026
Merged

Change detection in footnotes between main and compare plannings#2513
TruongQuangSB merged 11 commits into
mainfrom
change-detection-in-footnotes-of-compare-planning

Conversation

@mariusheine

@mariusheine mariusheine commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mariusheine mariusheine marked this pull request as draft July 2, 2026 11:01
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Test Results

145 tests  +9   145 ✅ +9   8m 32s ⏱️ ±0s
 40 suites +6     0 💤 ±0 
 40 files   +6     0 ❌ ±0 

Results for commit e02b928. ± Comparison against base commit 9b7e5d8.

This pull request removes 4 and adds 13 tests. Note that renamed tests count towards both.
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test6085206640323952394PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test11328744828764996661PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test6741676693205624392PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test5654322046691794509Info__2026-04-21_10-40.planpro
TableExtensionsTest CompareFootnoteContainer ‑ One single footnote container with unchanged, new and old footnote
TableExtensionsTest CompareTableFootnoteContainer ‑ simple compare planning with one removed and one new footnote
TableExtensionsTest Mix of footnote container types ‑ combined simple and compare footnote containers
TableExtensionsTest Mix of footnote container types ‑ footnote not changed in compare planning
TableExtensionsTest Mix of footnote container types ‑ footnote removed in one container of compare planning but still used in another
TableExtensionsTest Mix of footnote container types ‑ footnotes with overlaps between start-/zielzustand and change in compare planning
TableExtensionsTest SimpleFootnoteContainer ‑ One single footnote container
TableExtensionsTest Special cases ‑ Footnote with no Bearbeitungsvermerk
TableExtensionsTest Special cases ‑ No footnote containers available
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test7971856236298544443PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
…

♻️ This comment has been updated with latest results.

@mariusheine mariusheine marked this pull request as ready for review July 6, 2026 08:10
@mariusheine mariusheine requested a review from TruongQuangSB July 6, 2026 09:13
@mariusheine mariusheine requested a review from TruongQuangSB July 7, 2026 10:37
@TruongQuangSB

Copy link
Copy Markdown
Contributor

@mariusheine pls implementation the feature also for PDF and Excel export

@mariusheine

Copy link
Copy Markdown
Contributor Author

@mariusheine pls implementation the feature also for PDF and Excel export

@TruongQuangSB IMplemented

@mariusheine mariusheine requested a review from TruongQuangSB July 8, 2026 10:30
@TruongQuangSB TruongQuangSB merged commit ddfd854 into main Jul 8, 2026
17 checks passed
@TruongQuangSB TruongQuangSB deleted the change-detection-in-footnotes-of-compare-planning branch July 8, 2026 12:21
TruongQuangSB pushed a commit to SuB-PlanPro/set that referenced this pull request Jul 8, 2026
…ipse-set#2513)

* detect and display changes in footnotes between main and compare planning

* fix missing semicolon

* display removed footnotes as empty blue entries

* add some orizontal padding to changed footnotes

* use dispatch declaration

* fix pipeline build

* use leftPad instead of magic string

* simplify filtering for nested footnote containers

* simplify footnote determination at all

* fix return value

* add blue border around footnotes in pdf export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants