Change detection in footnotes between main and compare plannings#2513
Merged
TruongQuangSB merged 11 commits intoJul 8, 2026
Conversation
Test Results145 tests +9 145 ✅ +9 8m 32s ⏱️ ±0s Results for commit e02b928. ± Comparison against base commit 9b7e5d8. This pull request removes 4 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
TruongQuangSB
requested changes
Jul 7, 2026
Contributor
|
@mariusheine pls implementation the feature also for PDF and Excel export |
Contributor
Author
@TruongQuangSB IMplemented |
TruongQuangSB
approved these changes
Jul 8, 2026
TruongQuangSB
pushed a commit
to SuB-PlanPro/set
that referenced
this pull request
Jul 8, 2026
…ipse-set#2513) * detect and display changes in footnotes between main and compare planning * fix missing semicolon * display removed footnotes as empty blue entries * add some orizontal padding to changed footnotes * use dispatch declaration * fix pipeline build * use leftPad instead of magic string * simplify filtering for nested footnote containers * simplify footnote determination at all * fix return value * add blue border around footnotes in pdf export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.