Implement integration tests for fields with set and notifier#463
Draft
sahithi-nukala wants to merge 1 commit into
Draft
Implement integration tests for fields with set and notifier#463sahithi-nukala wants to merge 1 commit into
sahithi-nukala wants to merge 1 commit into
Conversation
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
3 times, most recently
from
4a9e897 to
8306eb3
Compare
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
from
8306eb3 to
38982b6
Compare
bemerybmw
requested changes
May 22, 2026
|
|
||
| // Note : at the moment the SkeletonField::Get implementation is not in the branch which means the skeleton and | ||
| // proxy side does not have same template parameters. | ||
| template <typename SampleType, bool EnableSet = false, bool EnableGet = false, bool EnableNotifier = false> |
Contributor
There was a problem hiding this comment.
Why did you reorder these?
Contributor
There was a problem hiding this comment.
Please put this change in a separate commit with a good description of why you're changing traits / traits_test.
| public: | ||
| using InterfaceTrait::Base::Base; | ||
|
|
||
| static constexpr bool kEnableSet{std::is_same_v<InterfaceTrait, SkeletonTrait>}; |
| load("@score_baselibs//score/language/safecpp:toolchain_features.bzl", "COMPILER_WARNING_FEATURES") | ||
| load("//quality/unit_testing:unit_testing.bzl", "cc_unit_test") | ||
|
|
||
| cc_library( |
Contributor
There was a problem hiding this comment.
Moving these should be a separate commit. You can read my comment here to better understand how commits should look / why we split them up: #385 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.