StyledText: drawing with block selection can be very slow #3523 - #3542
Open
tmssngr wants to merge 2 commits into
Open
StyledText: drawing with block selection can be very slow #3523#3542tmssngr wants to merge 2 commits into
tmssngr wants to merge 2 commits into
Conversation
…atform#3523 StyledText.getSelectionRanges() is quite expensive: for a larger number of selected rows it can take up to ~30-40ms on my machine. Invoking this method for each drawn row (!) is very inefficient, because it expensively calculates the same information again and again. Hence, we just invoke it one time for each drawLines invocation.
…e a point instance if we need it
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StyledText.getSelectionRanges() is quite expensive: for a larger number of selected rows it can take up to ~30-40ms on my machine. Invoking this method for each drawn row (!) is very inefficient, because it expensively calculates the same information again and again. Hence, we just invoke it one time for each drawLines invocation.
StyledTextRenderer.intersectingRelativeNonEmptySelections: only create a point instance if we need it