Skip to content

Add Java 28 Constants #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SougandhS merged 1 commit into from
Aug 20, 2026
Merged

Add Java 28 Constants #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ....jdt.launching/launching/org/eclipse/jdt/internal/launching/EECompilationParticipant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2008, 2025 IBM Corporation and others.
* Copyright (c) 2008, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -234,6 +234,8 @@
String version = vMInstall.getJavaVersion();
if (version == null) {
return null;
} else if (matchesMajorVersion(version, JavaCore.VERSION_28)) {

Check warning on line 237 in org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/EECompilationParticipant.java

View check run for this annotation

Jenkins - Eclipse JDT / Compiler

Member 

ERROR:
VERSION_28 cannot be resolved or is not a field
return JavaCore.VERSION_28;

Check warning on line 238 in org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/EECompilationParticipant.java

View check run for this annotation

Jenkins - Eclipse JDT / Compiler

Member 

ERROR:
VERSION_28 cannot be resolved or is not a field
} else if (matchesMajorVersion(version, JavaCore.VERSION_27)) {
return JavaCore.VERSION_27;
} else if (matchesMajorVersion(version, JavaCore.VERSION_26)) {
Expand Down
7 changes: 5 additions & 2 deletions org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/StandardVMType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -808,7 +808,10 @@
*/
public static URL getDefaultJavadocLocation(String version) {
try {
if (version.startsWith(JavaCore.VERSION_27)) {
if (version.startsWith(JavaCore.VERSION_28)) {

Check warning on line 811 in org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/StandardVMType.java

View check run for this annotation

Jenkins - Eclipse JDT / Compiler

Member 

ERROR:
VERSION_28 cannot be resolved or is not a field
// Java 28 docs aren't published yet
return new URI("https://docs.oracle.com/en/java/javase/26/docs/api/").toURL(); //$NON-NLS-1$
} else if (version.startsWith(JavaCore.VERSION_27)) {
// Java 27 docs aren't published yet
return new URI("https://docs.oracle.com/en/java/javase/26/docs/api/").toURL(); //$NON-NLS-1$
} else if (version.startsWith(JavaCore.VERSION_26)) {
Expand Down
8 changes: 6 additions & 2 deletions ...unching/org/eclipse/jdt/internal/launching/environments/ExecutionEnvironmentAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2006, 2025 IBM Corporation and others.
* Copyright (c) 2006, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -41,6 +41,7 @@ public class ExecutionEnvironmentAnalyzer implements IExecutionEnvironmentAnalyz

// XXX: Note that this string is not yet standardized by OSGi, see http://wiki.osgi.org/wiki/Execution_Environment

private static final String JavaSE_28 = "JavaSE-28"; //$NON-NLS-1$
private static final String JavaSE_27 = "JavaSE-27"; //$NON-NLS-1$
private static final String JavaSE_26 = "JavaSE-26"; //$NON-NLS-1$
private static final String JavaSE_25 = "JavaSE-25"; //$NON-NLS-1$
Expand Down Expand Up @@ -119,6 +120,7 @@ public class ExecutionEnvironmentAnalyzer implements IExecutionEnvironmentAnalyz
mappings.put(JavaSE_25, new String[] { JavaSE_24 });
mappings.put(JavaSE_26, new String[] { JavaSE_25 });
mappings.put(JavaSE_27, new String[] { JavaSE_26 });
mappings.put(JavaSE_28, new String[] { JavaSE_28 });
}
@Override
public CompatibleEnvironment[] analyze(IVMInstall vm, IProgressMonitor monitor) throws CoreException {
Expand All @@ -144,7 +146,9 @@ public CompatibleEnvironment[] analyze(IVMInstall vm, IProgressMonitor monitor)
types = getTypes(CDC_FOUNDATION_1_1);
}
} else {
if (javaVersion.startsWith("27")) { //$NON-NLS-1$
if (javaVersion.startsWith("28")) { //$NON-NLS-1$
types = getTypes(JavaSE_28);
} else if (javaVersion.startsWith("27")) { //$NON-NLS-1$
types = getTypes(JavaSE_27);
} else if (javaVersion.startsWith("26")) { //$NON-NLS-1$
types = getTypes(JavaSE_26);
Expand Down
3 changes: 2 additions & 1 deletion org.eclipse.jdt.launching/plugin.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
###############################################################################
# Copyright (c) 2000, 2025 IBM Corporation and others.
# Copyright (c) 2000, 2026 IBM Corporation and others.
#
# This program and the accompanying materials
# are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -89,6 +89,7 @@ environment.description.28 = Java Platform, Standard Edition 24
environment.description.29 = Java Platform, Standard Edition 25
environment.description.30 = Java Platform, Standard Edition 26
environment.description.31 = Java Platform, Standard Edition 27
environment.description.32 = Java Platform, Standard Edition 28

classpathVariableInitializer.deprecated = Use the JRE System Library instead

Expand Down
7 changes: 6 additions & 1 deletion org.eclipse.jdt.launching/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<?eclipse version="3.0"?>
<!--
Copyright (c) 2005, 2025 IBM Corporation and others.
Copyright (c) 2005, 2026 IBM Corporation and others.

This program and the accompanying materials
are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -409,6 +409,11 @@
id="JavaSE-27"
compliance="27">
</environment>
<environment
description="%environment.description.32"
id="JavaSE-28"
compliance="28">
</environment>
<analyzer
class="org.eclipse.jdt.internal.launching.environments.ExecutionEnvironmentAnalyzer"
id="org.eclipse.jdt.launching.eeAnalyzer"/>
Expand Down