Updated Dockerfiles, released GF 8.0.4 - #38
Open
dmatej wants to merge 3 commits into
Open
Conversation
- Always create a new domain (and new keystores) - Possibility to use alternative maven repository - Updated dependencies - autodeploy softlink - user readonly Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
marked this pull request as ready for review
August 5, 2026 22:33
OndroMih
approved these changes
Aug 15, 2026
| && mkdir -p "${PATH_GF_HOME}" \ | ||
| && curl -fL "https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-${GLASSFISH_VERSION}.jar.asc" -o glassfish-embedded-all.jar.asc \ | ||
| && curl -fL "https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-${GLASSFISH_VERSION}.jar" -o "${PATH_GF_HOME}"/glassfish-embedded-all.jar \ | ||
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar.asc" -o glassfish-embedded-all.jar.asc \ |
Contributor
There was a problem hiding this comment.
Shouldn't it be changed also here?
Suggested change
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar.asc" -o glassfish-embedded-all.jar.asc \ | |
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/@gf.docker.embedded.versionId@/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar.asc" -o glassfish-embedded-all.jar.asc \ |
| && curl -fL "https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-${GLASSFISH_VERSION}.jar.asc" -o glassfish-embedded-all.jar.asc \ | ||
| && curl -fL "https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-${GLASSFISH_VERSION}.jar" -o "${PATH_GF_HOME}"/glassfish-embedded-all.jar \ | ||
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar.asc" -o glassfish-embedded-all.jar.asc \ | ||
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar" -o "${PATH_GF_HOME}"/glassfish-embedded-all.jar \ |
Contributor
There was a problem hiding this comment.
And here?
Suggested change
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/${GLASSFISH_VERSION}/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar" -o "${PATH_GF_HOME}"/glassfish-embedded-all.jar \ | |
| && curl -fL "@gf.docker.mavenUrl@/org/glassfish/main/extras/glassfish-embedded-all/@gf.docker.embedded.versionId@/glassfish-embedded-all-@gf.docker.embedded.versionId@.jar" -o "${PATH_GF_HOME}"/glassfish-embedded-all.jar \ |
Contributor
|
Just 2 minor things, nothing that prevents merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.