Migrate to Harmonia version 3 - #7353
Draft
StanZGenchev wants to merge 3 commits into
Draft
Conversation
Signed-off-by: StanZGenchev <stan.genchev@codbex.com>
Signed-off-by: StanZGenchev <stan.genchev@codbex.com>
Signed-off-by: StanZGenchev <stan.genchev@codbex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the application layer to run on Harmonia 3.1.2.
It also fixes every Harmonia use that was invalid like:
It also fixes:
Changes
A lot of things changed. This is a very short summary of them:
3.1.2, Alpine to3.16.3, Lucide to1.20.0, pinecone-router to7.6.0, i18next to26.3.6x-h-sidebar-menu-navx-h-tab-item+aria-controls+x-h-tabs-contentx-h-list-item-button+aria-current<i x-h-lucide>was changed to<svg x-h-lucide>and decorative icons gotrole="presentation"--color-*tokens were moved to the official Harmonia color tokensdata-variant="emphasized"attributes were changed todata-variant="primary". "emphasized" is a BlimpKit thing, it doesn't exist in Harmonia.data-sizeremoved from dialogs/spinnerdata-filterwas moved to thex-h-select-searchelement$notifications.addx-h-bubblecomponentx-h-paginationis now used in the list/master/manage and report viewsx-h-badge-indicatordata-bordered="horizontal"table headers in Monitoring.claude/docs/harmonia-ui.mddoc to point at the upstream skillTests
I introduced a new guard test.
HarmoniaContractITreads the directive registry out ofdist/harmonia.min.js+harmonia-lucide.min.jsand the class allowlist out ofskills/harmonia/references/utility-classes.mdinside the pinned webjar, then scans every Harmonia page and checks for the use of non-existent components/directives.Not verified: the release-profile javadoc run (no javadoc binary on the build
machine) and the manual browser pass (theme sync into iframes and tabs, toast on
save, attachment-card padding screenshots).
What issues does this PR fix or reference?
#7352