intent: a create-from's items: has a source-row rule - where: + refuse: (#7091)

[delchev]

The mirror items: block of a create-from cloned every row of the source document into a target line, and nothing could say which rows qualified — GeneratesItemsIntent carried from/to/map/defaults and nothing else, and checks: lives on entities so it cannot gate a generate's item selection either.

base-timesheets invoice-from-timesheet therefore billed every EmployeeTimesheet of the project-month:

• a DRAFT / SUBMITTED / REJECTED member timesheet at the same footing as an APPROVED one — hours nobody has approved on the customer's invoice;
• an EMPTY one (totalHours null), whose mapped quantity the target refuses, blocked the whole Generate until someone deleted the row by hand — one person who never filed a day stopped the billing of everyone who did.

"Invoice the approved month" is the one flow a billing clerk runs, so the module could either bill unapproved hours or not bill at all. The gap is fleet-wide: proforma → invoice, quotation → order, order → invoice.

where: — the source-row rule

    items:
      from: EmployeeTimesheet
      to: SalesInvoiceItem
      where:
        - { field: Status,     op: eq, value: APPROVED }   # only approved member timesheets
        - { field: totalHours, op: gt, value: 0 }          # an empty one is not a line
      map: { Name: employeeName, Quantity: totalHours, Price: rate }

The same { field, op, value } triples a schedules[].where carries — ScheduleSupport.conditionChain is the shared renderer, extracted out of criteriaExpression — pushed into the very Criteria that already selects the source's rows by their master foreign key, so an unqualified row is never loaded. A moment value (CURRENT_DATE, CURRENT_TIMESTAMP-PT30M) is resolved against the clock of the run that generates.

A condition naming the source item's own function: EntityStatus relation may use the seeded status NAME, resolved on the item's nomenclature and never the document header's — resolving against the header's lifecycle would take an id out of the wrong nomenclature and filter on it silently. Only that one condition is a candidate, exactly as a register lookup's static filter is.

refuse: — the other reading

      refuse: "Member timesheet is not approved"

An unqualified row stops the whole create-from with the authored message plus the keys of the offending rows, instead of being left out. Which of the two a document means is a property of the document, not of the platform — a rejected timesheet quietly dropped from an invoice and a rejected timesheet quietly billed are both wrong, for different months — so skipping is the default, and refuse: without a where: is refused at parse (with no conditions no row is ever unqualified).

A rule that qualifies no row refuses too

Rather than committing a header with no lines at all: that is the harder of the two failures to notice, since the document exists, counts as the period's billing, and is empty.

Scope

Scoped to a where-declaring block — a rule-less items block regenerates byte-identical output, and the descriptor's two new keys default to the empty string in GlueGenerator.bindGenerate, so a .glue written before them renders the unfiltered clone loop it always had. Unlike a schedule's query, whose source may be a cross-model row or an audit: column this model cannot see, the rule reads a LOCAL row being cloned — so field: is checked against the item source's own fields and to-one relations at parse.

Tests

• GlueGeneratesItemsWhereTest (new, 8 cases): the rendered Criteria chain incl. the resolved status name and a moment value, the carried refusal, the rule-less descriptor unchanged, and each parse refusal.
• IntentEmissionCoverageIT: the emitted query and both refusals, then end to end — a mixed stay bills exactly its past nights, an all-unqualified one answers 400 Stay night carries no amount (StayNight [10, 11, 12]), and the same source under the skip rule answers 400 for the lineless document. Green locally (185 s).
• Full -P unit-tests reactor green; formatter:validate green; -P release javadoc clean on both touched modules.

Docs

• in-repo: engine-intent/CLAUDE.md, .claude/docs/intent-layer.md, intent-assistant-guide.md
• dirigible.io: docs(intent): which source rows become lines - generates items where: / refuse: (#7091) dirigible-io/dirigible-io.github.io#238
• intentfile.org spec proposal: proposal: which source rows become lines IntentFile/intent-specification#72 · site: spec site: which source rows become lines - generates items where: / refuse: IntentFile/intentfile.github.io#55

Fixes #7091

🤖 Generated with Claude Code