fix: isolate tests from developer-local configuration files - #157
Open
paullatzelsperger wants to merge 1 commit into
Open
fix: isolate tests from developer-local configuration files#157paullatzelsperger wants to merge 1 commit into
paullatzelsperger wants to merge 1 commit into
Conversation
LoadConfigOrPanic searches /etc/appname, $HOME/.appname and the working directory, so launcher-level tests inherited whatever config files a developer had (e.g. a postgres setting in ~/.appname/pm.env), making them fail or silently change behavior. A CFM_CONFIG_DIR environment variable now overrides the search path exclusively, and the new fixtures.IsolateConfig helper points it at an empty temp dir in every test that boots a launcher. Also fixes the broken env cleanup in TestLoadConfigFromEnvironment, which leaked TESTAPP_* variables into subsequent tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes
prevent test fixtures from reading local develop config from the filesystem, e.g.
~/.appname/