Improvements to test.ceylon.time

[lucaswerkmeister]

• Many, MANY tests were calling assertEquals with the wrong argument order: assertEquals(expected, actual), whereas the correct order with positional arguments is assertEquals(actual, expected). A few of these mistakes were caught by Implement #6172: parameter/argument warning ceylon#6183. I attempted to fix them in a way that would be consistent with other tests in the file, so sometimes I swapped the parameters, and sometimes I changed the invocation to use named arguments.
• Some tests did manual exception handling instead of using assertThatException.
• Some tests could be parameterized (ceylon.test: support parametrized tests #159).

[CeylonBuildBot]

Can one of the admins verify this patch? (see README)

[lucaswerkmeister]

CC @DiegoCoronel, @luolong

[tombentley]

@CeylonBuildBot ok to test

[luolong]

These could also be converted to named argument invocation style.
I find I've come to like it much more than ordinal invocation. Specially for test assertions.

this particualtr one would look much better imho if it was formatted like this:

shared test void testDateMinusLessDays() => assertEquals {
    actual = date(1982,december,31).minusMonths(1);
    expected = date(1982,november,30);
};

[lucaswerkmeister]

What about the test methods with more than one assertEquals? That would be a lot more lines…

[luolong]

Wow @lucaswerkmeister you must really have a ton of unaccounted for time on your hands :)

Thanks, this is much better now 👍

[luolong]

Should I merge it or do you want to make these last few adjustments...?

[lucaswerkmeister]

I can make the adjustments. Should I amend the existing commit or add another one?

[lucaswerkmeister]

Oh, I forgot I wanted to make another change as well – rename members like data_1982_12_13 to date_1982_12_13. Or is that not a typo?

[DiegoCoronel]

probably thats a typo @lucaswerkmeister .. in Brazil date is data .. probably I wrote in portuguese by mistake

[lucaswerkmeister]

Alright, all done except for the non-named arguments assertEquals in testDates.ceylon. Should I change them all to named arguments?

Also, the question of commits is still open… 7d2d111 should at least be squashed into c68b01e, but apart from that, I leave it to you if you want to merge the separate commits or a squashed commit. (I think squashing would make more sense.)

[luolong]

@lucaswerkmeister:

Should I amend the existing commit or add another one?

I guess, just adding commits to this PR is good enough... but if you like, you can squash tem .. the resulting history does look nicer when merged :)

(I personally have only seldom bothered to though)

[lucaswerkmeister]

Alright, I’ve pushed a squashed commit. (Also rebased on current master.)

[luolong]

Thanks Lucas!

[lucaswerkmeister]

You’re welcome! :)