fix(posting): Prevent TypeError when image/thumbnails metadata is not an array - #1853
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: .filter is not a functionoccurring inextractMetaDatawhen editing older Hive posts. The issue arises becausejson_metadata.imageorjson_metadata.thumbnailsfrom the blockchain can sometimes be a plain string (a single URL) instead of an array, due to the lack of strict schema in older blockchain data.The previous code used
(initialMeta.image ?? [])which only guarded againstnullorundefinedvalues. A string value would pass this check, leading to.filter()being called on a non-array type.The fix replaces
(initialMeta.image ?? [])and(initialMeta.thumbnails ?? [])with(Array.isArray(initialMeta.image) ? initialMeta.image : [])and(Array.isArray(initialMeta.thumbnails) ? initialMeta.thumbnails : [])respectively. This ensures that these fields are always treated as arrays (or empty arrays if they are not arrays), preventing theTypeError.Fixes ECENCY-NEXT-1GQM
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.