feat(security): add local pwned-password list - #10197
Open
BacLuc wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The password list is not good yet. (contains passwords with less than 12 characters). We need to decide: do we want to do this and make our users angry for the not so critical ecamp? (Maybe we should disclose that we do not treat ecamp3 as critical an no one should store medical data or other critical things in ecamp?). |
Member
Core Meeting DecisionWe do this and don't do #10198 |
BacLuc
force-pushed
the
check-password-against-breached-passwords
branch
from
August 9, 2026 08:26
31b791c to
ffd421d
Compare
BacLuc
force-pushed
the
check-password-against-breached-passwords
branch
2 times, most recently
from
August 16, 2026 12:20
fd9f7ec to
aecff60
Compare
✅ Feature branch deployment ready!
|
BacLuc
marked this pull request as ready for review
August 16, 2026 12:31
Add NotPwnedPasswordValidator, which checks a local plaintext list generated from a pinned SecLists Xato password source. The Symfony generator keeps the first 3000 unique passwords with at least 12 UTF-8 characters and performs case-insensitive deduplication. Runtime validation performs no external HTTP calls or prehashing, and rejects case variants of listed passwords. Keeping the generated list local avoids production and test dependencies on remote availability. This supports OWASP ASVS 6.2.4: https://github.com/OWASP/ASVS/blob/master/4.0/en/0x11-V2-Authentication.md#v21-password-security
BacLuc
force-pushed
the
check-password-against-breached-passwords
branch
from
August 16, 2026 15:57
aecff60 to
aa9c8ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NotPwnedPasswordValidator, which checks a local plaintext list generated from a pinned SecLists Xato password source. The Symfony generator keeps the first 3000 unique passwords with at least 12 UTF-8 characters and performs case-insensitive deduplication.
Runtime validation performs no external HTTP calls or prehashing, and rejects case variants of listed passwords. Keeping the generated list local avoids production and test dependencies on remote availability.
This supports OWASP ASVS 6.2.4: https://github.com/OWASP/ASVS/blob/master/4.0/en/0x11-V2-Authentication.md#v21-password-security