🧪 Service-backed tests fail loudly instead of skipping when the vector service is required

[ebigunso]

Summary

v0.1.6 Wave 1, Task_1 (live-gate hardening), targeting the planning branch per the phase's merge shape.

• One environment switch (REQUIRE_QDRANT_TESTS) honoured by the shared test support turns every typed Qdrant-unavailable skip into a panic; all eight former skip sites route through it.
• Both prose-matched timeout skip branches are removed; no test gates on error text.
• The service-backed CI job sets the switch, so a missing service fails the job rather than silently passing.

Validation

• Worker (cm-worker2): service-up cargo test with the switch set, 405 passed / 0 failed / 3 pre-existing ignored; collection census 0 before / 0 after; fmt and Clippy -D warnings clean.
• Reviewer (cm-reviewer, Tier D): approved at a633b2e, no findings; forced-down controls with the switch set fail the exact former skip sites instead of passing.

🤖 Generated with Claude Code

[Copilot]

🟢 Approval recommended

The centralized gate consistently covers every former typed skip site, while CI enables strict failure behavior.

Pull request overview

Hardens Qdrant-backed tests so required service failures cannot be silently skipped.

Changes:

• Adds a shared environment-controlled skip-or-panic gate.
• Routes all eight typed Qdrant-unavailable paths through it and removes prose-based timeout skipping.
• Enables strict behavior in service-backed CI.

File summaries

File	Description
tests/support/base.rs	Adds the strict Qdrant availability gate.
tests/support/mod.rs	Re-exports the new helper.
tests/write_planning_tests.rs	Hardens setup handling and removes timeout-text matching.
tests/retrieval_guardrails_tests.rs	Applies strict availability handling to three tests.
tests/public_facade_tests.rs	Applies strict availability handling to two tests.
tests/initialization_tests.rs	Applies strict availability handling during initialization.
.github/workflows/pr_validation.yaml	Requires Qdrant in the integration-test job.

Review details

• Files reviewed: 7/7 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

All service-unavailable skip paths now honor the required-service gate, and no error-text matching remains.

Review details

• Files reviewed: 7/7 changed files
• Comments generated: 0 new
• Review effort level: Balanced