Repository navigation
fix(recovery): preserve candidates after prelaunch failures - #276
Merged
Merged
Conversation
ebarti
added a commit
that referenced
this pull request
Nov 1, 2026
Stopped deliveries can retain an unchanged candidate while cleanup, ownership, effects or a repair allowance still prevent continuation. Selected recovery routes now expose versioned lifecycle observations and typed blockers from the same owner checks used by admission. Historical repair rechecks its frozen run, claim, work/repository binding, attempts and effects inside the admission transaction. Exact command replay validates the required receipt fields and workflow identity against retained grants, admissions and events. Corrupt or conflicting receipts fail closed; later workflow progress does not invalidate an authentic earlier receipt. Historical repair and stopped-resume records cannot independently reconstruct every presentation field, so those limits remain explicit. This is a bounded contribution to #240. Pre-plan same-run recovery, typed refusals for every owner and replacement of existing error-text classification remain open. The gate guard overlaps #276 and requires reviewed integration before joint delivery. Native descendant settlement and full issue acceptance are not established here. Validation on `8121ac2981c00fd20636300126562bd7feb1add3`: - 32 affected local cases passed, including public API, Git/SQLite, local Temporal, concurrent identical admissions and replay after later admissions. - Runtime Ruff and diff checks passed. - Hosted Check 41332643263 and current CodeQL passed on the exact head/base. Five jobs, both ZIP digests, and four complete disjoint reports/JUnit were authenticated: 1,426 runtime passes and 188 source passes. Four existing runtime and three existing source opt-in/capability skips remain unexecuted. This is configured hosted-gate qualification, not production or full issue acceptance.
ebarti
added a commit
that referenced
this pull request
Nov 1, 2026
Checkpoint readback could advertise an old acknowledgement as resumable after the run budget, owner, workspace, candidate branch, index, evidence or session content changed. Check current facts under existing resource/writer custody, preserve the original acknowledgement, and keep restore as the authoritative admission boundary. Retained evidence uses opened files without following links, bounded reads, and revalidated metadata and parent identity. Missing reconstructible files remain eligible for restore. Changed, inaccessible or unverified existing state produces a blocker and is preserved; strict retained verification keeps its missing-file refusal. This is a bounded contribution to #239. The integrated recovery scenario uses real local Temporal with a fixture provider and controlled remote/effect boundaries. Complete native descendant settlement, real-provider continuation and integrated running pause/resume remain open under #242 and #245. No active installation or delivery was changed. Validation of unchanged integration tree `8e29a2898fea5c4f330b3e714875bf46a52c2bee` (current head `c8f7f581b783ad3692817a99358572fe5edc0b07`), based on #276: - Four existing public checkpoint, retained verification, stopped-recovery and local Temporal composition cases passed in 25.25 seconds; no skips. The checkpoint repair passed 16 related cases before dependency integration. - Runtime Ruff, independent tree reconstruction, signature verification and unchanged per-layer diffs passed. - Full hosted Check 41338611603 is under qualification on the final native head/base; earlier results do not qualify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient prelaunch stop can abandon a retained passing implementation and schedule product repair. Authenticate candidate-bound readiness refusals and add a finite zero-repair continuation that preserves the original attempt, selectors, owner, effects and product allowance. Two readiness retries use 30- and 60-second backoff from authenticated predecessor closure; waiting creates no attempt, effect or grant.
Early feature-review preparation failures are distinguished from genuine findings through sealed revision/proposal identity, typed terminal supervisor evidence and held owner/resource leases. This integration consumes #274 while preserving its typed predicates and every readiness, worker-handoff and custody check.
This is a bounded contribution to #243. Native retry remains refused without complete descendant settlement. Feature reservation/GO reconciliation, other infrastructure routes, generic early-prelaunch observation and full public product-repair acceptance remain open.
Validation of unchanged integration tree
849152544b063227aa4fb76cd6dc437d30c18e37(current head200a4d80dd3614dab27c00a63655ab5c7d41c900), based on #274: